Add new build Action #280
Merged
Add new build Action #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new build Action while keeping the current release Action intact. The intent is to incrementally gain confidence in the new Action by operating both workflows in parallel for some time. The new build Action is, in fact, not entirely new. See prior art in [Terraform Core](https://github.com/hashicorp/terraform/blob/main/.github/workflows/build.yml) and other repos. Here are a few benefits for official Terraform providers: * Matrixed Go builds * Single responsibility -- build-only, rather than build and release * ZIP archives uploaded as GitHub Actions artifacts for further processing by other Actions
|
|
austinvalle
approved these changes
Nov 19, 2024
Comment on lines
+30
to
+36
| # We use .go-version as our source of truth for current Go | ||
| # version, because "goenv" can react to it automatically. | ||
| # Specify the exact Go version (e.g., 1.22.4) in .go-version | ||
| # if your build requires a specific patch version of Go. | ||
| # Otherwise, specify the major and minor versions (e.g., 1.22), | ||
| # with a caveat that it can lead to builds using different | ||
| # patch versions of Go in a workflow run. |
There was a problem hiding this comment.
Interesting! I wonder if now that the Go toolchain defaults to including patch version details in the go.mod, if we really need this static file in the future 🤔
| - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2 | ||
| - name: Set Product version | ||
| id: set-product-version | ||
| uses: hashicorp/actions-set-product-version@v1 |
There was a problem hiding this comment.
nit: in the future we should probably point their actions to the commit hash (also noticed they have a v2 that their example is not updated to use 😆 )
Our internal tool TSCCR doesn't support pinning/upgrading hashicorp actions for us 🙃
https://github.com/hashicorp/security-tsccr/issues/674
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new build Action while keeping the current release Action intact. The intent is to incrementally gain confidence in the new Action by operating both workflows in parallel for some time.
Any builds generated by this Action will simply be uploaded as Actions artifacts and go nowhere beyond that.
The new build Action is, in fact, not entirely new. See prior art in Terraform Core and other repos. Here are a few benefits for official Terraform providers: