You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is this issue currently blocking your project? (yes/no): No
is this issue affecting a production system? (yes/no): No
Context
node version: n/a
module version: n/a
environment (e.g. node, browser, native): node
used with (e.g. hapi application, another framework, standalone, ...): hapi application
any other relevant information: n/a
What problem are you trying to solve?
Yar makes use of uuid.v4(). Given that dropping support for Node 12 is being proposed at hapijs/hapi#4279. Is it worth considering to use the Node's built-in support for UUID v4 (crypto.randomUUID)?
Do you have a new or modified API suggestion to solve the problem?
Not necessary, change would be an implementation detail, but support for Node 12 must be dropped. It is also worth mentioning that crypto.randomUUID is only available from Node 14.17
The text was updated successfully, but these errors were encountered:
I think it makes sense to require node 14.17+. It has been out for close to 5 months, and likely more than 6 once this change would be published. Hapi is already known for aggressive node runtime requirements.
It would make sense indeed. Thanks @jonathansamines for raising this. Usually it's pretty straightforward for users to increase their minor/patch versions of Node so I'd expect this version requirements not to be pretty problematic. We'd have to flag it breaking changes though since we're dropping Node@12 by using it.
Support plan
Context
What problem are you trying to solve?
Yar makes use of uuid.v4(). Given that dropping support for Node 12 is being proposed at hapijs/hapi#4279. Is it worth considering to use the Node's built-in support for UUID v4 (crypto.randomUUID)?
Do you have a new or modified API suggestion to solve the problem?
Not necessary, change would be an implementation detail, but support for Node 12 must be dropped. It is also worth mentioning that
crypto.randomUUID
is only available from Node 14.17The text was updated successfully, but these errors were encountered: