Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nes #132

Closed
Slayug opened this issue May 4, 2019 · 2 comments
Closed

Support nes #132

Slayug opened this issue May 4, 2019 · 2 comments
Labels
feature New functionality or improvement

Comments

@Slayug
Copy link

Slayug commented May 4, 2019

Hello,
I'm using Yar for my endpoints and works fine,
but I also want to make it works with Nes through websockets and recover same users I set in my endpoint.
Yar object is present into my request object when using Nes route:

// Route subscribed with Nes
this.route({
            method: 'POST',
            path: '/{id}/toast',
            config: {
                handler: function(request, h) {
                    console.log('toast posted:', request.yar._store)

But the store is always empty, event if I set something into it.
I looked a bit the code, it seems Nes is executed before Yar, its not on same level.

Is there a way to make Yar available with Nes routes ?

@hueniverse
Copy link
Contributor

It will require special handling in yar to store the session information on the socket instead of as a cookie.

@hueniverse hueniverse self-assigned this Sep 17, 2019
@hueniverse hueniverse added the feature New functionality or improvement label Sep 22, 2019
@hueniverse hueniverse changed the title Feat request with Nes Support nes Sep 23, 2019
@hueniverse hueniverse removed their assignment Jul 5, 2020
@lloydbenson
Copy link
Contributor

@Slayug: it looks like this is unlikely to happen without community effort. I am closing this up, but I think we'd be open to a PR later if you find time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

3 participants