Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yar doesn't handle the session cookie multiple times correctly. #124

Closed
SimonSchick opened this issue Sep 23, 2018 · 3 comments · May be fixed by micahlmartin/yar#3
Closed

Yar doesn't handle the session cookie multiple times correctly. #124

SimonSchick opened this issue Sep 23, 2018 · 3 comments · May be fixed by micahlmartin/yar#3
Assignees
Labels
bug Bug or defect
Milestone

Comments

@SimonSchick
Copy link
Contributor

Apparently https://github.com/hapijs/yar/blob/master/lib/index.js#L85 request.state[settings.name] can be an array, not just an object, yar should probably handle that.

I am not sure what yar should do, probably revoke the cookie(s) as it's technically invalid or just use the first valid one.

I know this isn't exactly intended behaviour but this came up when a colleague was debugging some of our endpoints with postman which for whatever reason duplicated cookies.

@SimonSchick
Copy link
Contributor Author

cc @Crashdoom

@hueniverse hueniverse self-assigned this Sep 24, 2018
@hueniverse hueniverse added the bug Bug or defect label Sep 24, 2018
@hueniverse hueniverse added this to the 9.0.2 milestone Sep 24, 2018
@SimonSchick
Copy link
Contributor Author

That didn't take long 😄

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants