chore: Fix golang lint errors

Author: lo5

cycbuf.go

@@ -20,10 +20,6 @@ type CycBuf struct {
 	i int
 }
 
-func newCycBuf(t Typ, n, i int) *CycBuf {
-	return &CycBuf{newFixBuf(t, n), i}
-}
-
 func (b *CycBuf) put(ixs interface{}) {
 	if xs, ok := ixs.([]interface{}); ok {
 		for _, x := range xs {

parse.go

@@ -33,21 +33,21 @@ const (
 	EXABYTE
 )
 
-var invalidByteSizeError = errors.New("invalid byte size")
+var errInvalidByteSize = errors.New("invalid byte size")
 
 // ParseBytes parses string representations (e.g. 42K or 42KB or 42KiB) to bytes
 func ParseBytes(s string) (uint64, error) {
 	s = strings.ToUpper(strings.TrimSpace(s))
 	i := strings.IndexFunc(s, unicode.IsLetter)
 
 	if i == -1 {
-		return 0, invalidByteSizeError
+		return 0, errInvalidByteSize
 	}
 
 	num, unit := s[:i], s[i:]
 	b, err := strconv.ParseFloat(num, 64)
 	if err != nil || b < 0 {
-		return 0, invalidByteSizeError
+		return 0, errInvalidByteSize
 	}
 
 	switch unit {
@@ -66,6 +66,6 @@ func ParseBytes(s string) (uint64, error) {
 	case "B":
 		return uint64(b), nil
 	default:
-		return 0, invalidByteSizeError
+		return 0, errInvalidByteSize
 	}
 }

parse_test.go

@@ -20,11 +20,6 @@ import (
 	"github.com/h2oai/wave/pkg/assert"
 )
 
-type parseBytesTestCase struct {
-	input  string
-	output uint64
-}
-
 func TestParseBytes(t *testing.T) {
 	_, ok, no := assert.Assert(t)
 	units := []string{"e", "p", "t", "g", "m", "k"}
@@ -38,7 +33,7 @@ func TestParseBytes(t *testing.T) {
 
 		b, err = ParseBytes("0" + unit)
 		no(err)
-		ok(0 == b, "zero")
+		ok(b == 0, "zero")
 
 		b, err = ParseBytes("5" + unit + "b")
 		no(err)