-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker development Windows install instructions #115
Comments
Here are the updated instructions for installing Docker on Windows: Check the system requirements: Docker Desktop for Windows requires 64-bit Windows 10 Pro, Enterprise, or Education version 1809 or later, with Hyper-V enabled. You also need at least 4GB of RAM. # Download Docker Desktop for Windows: Go to the Docker website and download the Docker Desktop for Windows installer. Run the installer: Double-click the installer to start the installation process. If prompted, allow the installer to make changes to your system. Configure Docker: After the installation is complete, Docker Desktop launches automatically. You can configure Docker by clicking the Docker icon in the system tray and selecting "Settings". Here, you can adjust settings such as the amount of memory and CPU Docker is allowed to use. Verify installation: Open a command prompt or PowerShell window and run the command docker version to verify that Docker is installed and running correctly. Start using Docker: You can start using Docker by running Docker commands in a command prompt or PowerShell window. You can also use a graphical user interface such as Kitematic to manage your Docker containers. That's it! With these steps, you should now have Docker up and running on your Windows machine. |
Thanks @InfasMohammed! Can you make a PR with these instructions in the Windows section of this readme? |
Also please verify, if git clone https://github.com/h2oai/wave-apps.git
cd wave-apps/docker-development
docker build . -t wave_local_dev
docker run -p 10101:10101 -v $(pwd)/src:/app/src wave_local_dev:latest work on windows as well and successfully allow you to go to |
Hey @mturoci, I verified it on Windows and I got the "Hi, Hello World!" message. Regards, |
Yes @devarsh10, that's right. You can update the README accordingly - the instructions are the same for all OSes. |
Okay @mturoci, I just have to add the Docker installation steps right? |
No. That's covered in https://www.docker.com/. The goal is to make it clear how to run the dockerized app - https://github.com/h2oai/wave-apps/tree/main/docker-development. The wording used may be a bit confusing so we can change |
Could you assign me this issue under hacktoberfest? |
@harshjais369 you can go ahead. We do not assign issues. |
One simpler method is to append docker-development/README.md:20 to include |
Changes - Implements issue h2oai#115 suggestion for improved verbage.
I have both implemented in #123 |
Update the Windows install instructions in https://github.com/h2oai/wave-apps/tree/main/docker-development, based on the UNIX ones.
The text was updated successfully, but these errors were encountered: