Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpliftDRF - fix find best split point #16052

Closed
maurever opened this issue Jan 31, 2024 · 0 comments
Closed

UpliftDRF - fix find best split point #16052

maurever opened this issue Jan 31, 2024 · 0 comments
Assignees
@maurever
Labels
bug
Milestone
3.46.0.1

Comments

@maurever
Copy link
Contributor

In some cases, the best gain calculation is laid to be Infinity, and the find best split point method returns an incorrect split.
@maurever maurever added the bug label Jan 31, 2024
@maurever maurever added this to the 3.46.0.1 milestone Jan 31, 2024
@maurever maurever self-assigned this Jan 31, 2024
@maurever maurever mentioned this issue Jan 31, 2024
Merged
maurever added a commit that referenced this issue Feb 2, 2024
@maurever
GH-16052 UpliftDRF Fix find best split point (#16053)
ba5aedf 
* UpliftDRF Fix find best split point

* Fix smoke tests
@maurever maurever closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurever maurever

Labels
bug
Projects
None yet
Milestone
3.46.0.1
Development

No branches or pull requests
1 participant
@maurever