Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

Button.state().reset() clears button text if set via Button.setText(String text) #486

Open
twistedpair opened this issue Feb 23, 2014 · 4 comments
Assignees
Labels

Comments

@twistedpair
Copy link
Contributor

I noticed this behavior:

I need to set the button "text" label to a dynamic string, so it is set via myButton.setText("someText") This correctly sets the text label on the button.

However, when I call myButton.state().reset() the button's text is cleared. If the text is set from the UiBinder with <Button text="someText" /> it is not cleared when myButton.state().reset() is called.

I noticed that the code is surprisingly complex with Button#text(String text), and I wonder if this behavior is due to that. If I knew better what that code was attempting to accomplish, I could try to contribute a patch. Thanks.

@reinert
Copy link
Contributor

reinert commented Feb 24, 2014

@twistedpair I would appreciate if you could assert the issue is solved.

@reinert reinert self-assigned this Feb 24, 2014
@reinert reinert added the bug label Feb 24, 2014
@twistedpair
Copy link
Contributor Author

Thanks for the quick response @reinert

Checked out the HEAD from the repo, built snapshot locally and recompiled project and ran. The problem still persists. You checked into master, right?

@reinert
Copy link
Contributor

reinert commented Feb 28, 2014

That's right. I'll solve this issue as soon as possible.

@twistedpair
Copy link
Contributor Author

@reinert Thanks again for your help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants