Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storybook to run in a separate app in CSNX #1707

Open
5 of 7 tasks
oliverabrahams opened this issue Sep 16, 2024 · 0 comments
Open
5 of 7 tasks

Move storybook to run in a separate app in CSNX #1707

oliverabrahams opened this issue Sep 16, 2024 · 0 comments
Assignees

Comments

@oliverabrahams
Copy link
Contributor

oliverabrahams commented Sep 16, 2024

storybook is starting to depend on new versions of react/react-dom than we want to develop against (we want to support a wider range of versions than the latest).

this make it hard to install storybook and the version of react we want in the same package.

if we move storybook to its own app, it can use whatever deps it likes while we continue to develop the source packages at the lowest version of react we support.

this has a second benefit, in that storybook becomes a de facto consumer of source, rather than can of component unit test.

this will give us a much truer picture of what we're exporting, and removes a footgun for contributors whereby exports that have not been added will not available to storybook (e.g. #1653 (review))

Tasks

@sndrs sndrs self-assigned this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants