Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch from master to main #139

Open
sophie-h opened this issue Mar 27, 2021 · 10 comments
Open

Rename default branch from master to main #139

sophie-h opened this issue Mar 27, 2021 · 10 comments

Comments

@sophie-h
Copy link
Contributor

Posting this in release since I think all repos should be changed.

Maybe do this before the hackfest such that we can fix everything that is affected by this during the weekend?

@sdroege
Copy link
Member

sdroege commented Mar 27, 2021

As a first step this needs some documenting of the impact of this. Apart from switching the default branch in git, what is assuming a branch named "master"?

Probably the CI scripts, probably @GuillaumeGomez's release scripts. What else?

Also how do we make sure that people actually notice this change and we don't get bug reports in a few months from people running from a completely outdated master branch?

@sophie-h
Copy link
Contributor Author

Also how do we make sure that people actually notice this change and we don't get bug reports in a few months from people running from a completely outdated master branch?

https://github.com/github/renaming/ sounds like github got us covered for many things.

Some background information https://about.gitlab.com/blog/2021/03/10/new-git-default-branch-name/. Looks like main will be the default in the majority of place pretty soon. Maybe it's less pain to do the change now.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Mar 28, 2021

The default branch for cargo is master. Another thing to be taken into account (for our end users).

@sophie-h
Copy link
Contributor Author

The default branch for cargo is master. Another thing to be taken into account (for our end users).

The branch for cargo new depends on init.defaultBranch. Support for using the remotes default branch is only waiting for a release I guess https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-152-2021-05-06.

@GuillaumeGomez
Copy link
Member

Not for new projects, for projects using gtk-rs as a dependency.

@sophie-h
Copy link
Contributor Author

Not for new projects, for projects using gtk-rs as a dependency.

Yes I answered this in my comment too. Also, this change will probably be transparent for end users because GitHub redirects the branch https://about.gitlab.com/blog/2021/03/10/new-git-default-branch-name/ (also mentioned before.)

@GuillaumeGomez
Copy link
Member

Oh indeed, well, that's one less concern then.

@sophie-h
Copy link
Contributor Author

Progress with Rust 1.53

Cargo no longer assumes the default HEAD of git repositories is named master. This means you no longer need to specify branch = "main" for git dependencies from a repository where the default branch is called main.

https://blog.rust-lang.org/2021/06/17/Rust-1.53.0.html#head-branch-name-support-in-cargo

@sdroege
Copy link
Member

sdroege commented Jun 20, 2021

Should we then maybe do it before the release now? :) @GuillaumeGomez @bilelmoussaoui ?

@bilelmoussaoui
Copy link
Member

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants