Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Groups and Network Interfaces are not filtered by time correctly #826

Open
arengifo-lbx opened this issue Jan 13, 2025 · 2 comments
Assignees

Comments

@arengifo-lbx
Copy link

arengifo-lbx commented Jan 13, 2025

Hi.

When running cloud-nuke this way...

cloud-nuke aws --dry-run --region us-east-1 --newer-than 24h --resource-type security-group,network-interface

I'm getting the list of all my security groups and network interfaces, even those that older than 24 hours. It seems the time filter is not working correctly for those resource types. Based on the documentation, security groups and network interfaces are supported by time filters in the configuration file (although I'm not using any config file, just CLI parameters).

@arengifo-lbx arengifo-lbx changed the title Security Groups are not filtered by time correctly Security Groups and Network Interfaces are not filtered by time correctly Jan 13, 2025
@james03160927 james03160927 self-assigned this Jan 13, 2025
@james03160927
Copy link
Contributor

Thanks for flagging this issue @arengifo-lbx. I'll try to reproduce the same issue and come up with the fix soon.

@james03160927
Copy link
Contributor

Hi @arengifo-lbx, based on my investigation, I noticed that the security group time filter relies on the cloud-nuke-first-seen tag rather than the actual creation date. Does this align with your expectations, or were you intending to filter based on the creation date instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants