Webhook considers HTTP 201 an error

[tennox]

Describe the current behavior

My webhook target (windmill) returns HTTP 201, and grist seems to consider this an error:

{"status":"retrying","numWaiting":92,"updatedTime":1726065614947,"lastEventBatch":{"status":"failure","httpStatus":201,"errorMessage":"0191e187-1ff1-2d4e-8058-c1e4e0825982","size":68,"attempts":14},"lastSuccessTime":null,"lastFailureTime":1726065614947,"lastErrorMessage":"0191e187-1ff1-2d4e-8058-c1e4e0825982","lastHttpStatus":201}

Steps to reproduce

1. Have a webhook URL that returns HTTP 201
2. See grist in status failure

Describe the expected behavior

No response

Where have you encountered this bug?

• On docs.getgrist.com
• On a self-hosted instance

Instance information (when self-hosting only)

No response

[paulfitz]

Thanks for reporting this @tennox ! You're right, our behavior looks naive:

grist-core/app/server/lib/Triggers.ts

Lines 801 to 804 in 963e26d

	if (response.status === 200) {
	await this._stats.logBatch(id, 'success', { size, httpStatus: 200, error: null, attempts: attempt + 1 });
	return true;
	}