Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Development] Some tests fail even when run on fresh clone #1185

Open
2 tasks done
hexaltation opened this issue Aug 29, 2024 · 0 comments
Open
2 tasks done

[Development] Some tests fail even when run on fresh clone #1185

hexaltation opened this issue Aug 29, 2024 · 0 comments
Assignees

Comments

@hexaltation
Copy link
Collaborator

hexaltation commented Aug 29, 2024

Describe the current behavior

Submitting PR #1181 I discover that some tests fails.
Ex. Fork
Testing locally I can't maid them pass, even when removing all my changes.
Testing on main branch, the same tests fails.

I've done a experiment with PR #1184

  • Create a new branch from main
  • Change a word in CONTRIBUTING.md
  • Push and submit PR
  • Most at least 4/9 steps fail

Steps to reproduce

  1. Have a fresh clone, stay on main branch
  2. Setup the environment according to https://github.com/gristlabs/grist-core/blob/bbb9071175616890848993b85413de6b044b4052/documentation/develop.md
  3. run
GREP_TESTS="Fork" yarn test

Describe the expected behavior

Tests must pass when run in dev environment on main branch.

Where have you encountered this bug?

  • Local dev env
  • github CI

Instance information (when self-hosting only)

Local development machine.
Operating System: Arch Linux
Kernel: Linux 6.6.47-1-lts
Architecture: x86-64
Two screens
x11 with i3 as windows manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants