dynamically created nested grid disappeared when dragging out (doesn't restore)

[jujingyi520]

Watch the video https://gridstackjs.com/demo/nested_advanced.html

video_10086.mp4

[adumesny]

yep, I see that...

[jujingyi520]

May I ask when you would like to fix this BUG ^ - ^

[adumesny]

not high on my priority as I don't use nested grid at work, let alone dynamically nested grids. You can donate if you want it fixed sooner - reach out on slack. thanks.

[jujingyi520]

The function "removeAsSubGrid" adds a judgment to ensure that it is not eliminated

  removeAsSubGrid(nodeThatRemoved) {
    if (!nodeThatRemoved._event) {
      return
    }
    const pGrid = this.parentGridNode?.grid
    if (!pGrid) return
    pGrid.batchUpdate()
    pGrid.removeWidget(this.parentGridNode.el, true, true)
    this.engine.nodes.forEach((n) => {
      // migrate any children over and offsetting by our location
      n.x += this.parentGridNode.x
      n.y += this.parentGridNode.y
      pGrid.makeWidget(n.el, n)
    })
    pGrid.batchUpdate(false)
    if (this.parentGridNode) delete this.parentGridNode.subGrid
    delete this.parentGridNode
    // create an artificial event for the original grid now that this one is gone (got a leave, but won't get enter)
    if (nodeThatRemoved) {
      window.setTimeout(() => Utils.simulateMouseEvent(nodeThatRemoved._event, "mouseenter", pGrid.el), 0)
    }
  }

[adumesny]

why are you closing this when it is not fixed in the lib ? are yu saying the first 2 lines fixes the issue now ?

[jujingyi520]

Yes.

[jujingyi520]

Are you still working after 6:00 at night? It is half past ten Beijing time. 😃

[adumesny]

you can submit a code review and get credit with the fix. thanks.
and I'm always working :) (weekend for this lib. Sunday night right now)