ValuesOfCorrectTypeRule missing in specifiedSDLRules

[Yogu]

specifiedSDLRules, which is used in buildASTSchema, does not include the ValuesOfCorrectTypeRule validation rule. I think this rule is needed to e.g. reject true where an object literal would be expected on a directive argument.

[IvanGoncharov]

@Yogu Thanks for pointing this out 👍

The problem here is that ValuesOfCorrectTypeRule requires a full schema with all types in it and during SDL validation we have only AST.
The correct solution would be to build schema (with error recovery) first and only then use it for validation.
For example here is how TS deal with such issue:
https://www.typescriptlang.org/play?#code/C4TwDgpgBAYg9nKBeKBvAUFKBDA-ALigGVgAnASwDsBzTKAIwKgCF0BfddAMwFdKBjYOTiUoXABRcEheHACUaDt3GochAEQBWdWznLV9Ddt1QA9KagBJapTikIAZzHkIAGwAmUOFyh8A1rYA7qKgkJwSqtiEmrr6UPzRukA

So coding error recovery for buildASTSchema is not as simple as it looks we can't just ignore invalid fields (otherwise we will generate errors for every place where this field is used) we need to figure out a way to have "InvalidType" object of some kind.

TLDR It's something we need to fix but it requires big changes in how buildASTSchema works.