-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document or lint as much as possible of our code style #2604
Milestone
Comments
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a pretty uniform codebase which is very important for the reference implementation.
That said I the price that we pay for this it's extremely hard to start contributing since you get a huge amount of review comments in your first PR.
Also, it gave the wrong incentives to maintainers (including myself) to just rewriting PR from scratch since it was way easier than to explain what's wrong with the code.
Don't think that there is any silver bullet but we can do a couple of things:
CONTRIBUTION.md
I think a good strategy would be to first work on common issues that most of the first-time contributors struggling with:
index.js
and one of the top level foldersThe text was updated successfully, but these errors were encountered: