Fix bunch of edge cases with empty strings (#2178)

Author: IvanGoncharov

Diff for: .flowconfig

@@ -11,7 +11,7 @@
 
 [lints]
 sketchy-null-bool=off
-sketchy-null-string=off
+sketchy-null-string=error
 sketchy-null-number=error
 sketchy-null-mixed=error
 sketchy-number=error

Diff for: src/jsutils/invariant.js

@@ -3,6 +3,8 @@
 export default function invariant(condition: mixed, message?: string): void {
   const booleanCondition = Boolean(condition);
   if (!booleanCondition) {
-    throw new Error(message || 'Unexpected invariant triggered');
+    throw new Error(
+      message != null ? message : 'Unexpected invariant triggered',
+    );
   }
 }

Diff for: src/language/source.js

@@ -23,7 +23,7 @@ export class Source {
 
   constructor(body: string, name?: string, locationOffset?: Location): void {
     this.body = body;
-    this.name = name || 'GraphQL request';
+    this.name = name != null ? name : 'GraphQL request';
     this.locationOffset = locationOffset || { line: 1, column: 1 };
     devAssert(
       this.locationOffset.line > 0,

Diff for: src/utilities/buildClientSchema.js

@@ -350,9 +350,10 @@ export function buildClientSchema(
 
   function buildInputValue(inputValueIntrospection) {
     const type = getInputType(inputValueIntrospection.type);
-    const defaultValue = inputValueIntrospection.defaultValue
-      ? valueFromAST(parseValue(inputValueIntrospection.defaultValue), type)
-      : undefined;
+    const defaultValue =
+      inputValueIntrospection.defaultValue != null
+        ? valueFromAST(parseValue(inputValueIntrospection.defaultValue), type)
+        : undefined;
     return {
       description: inputValueIntrospection.description,
       type,

Diff for: src/utilities/extendSchema.js

@@ -222,7 +222,7 @@ export function extendSchema(
   }
 
   function getMaybeTypeByName(typeName: ?string): ?GraphQLNamedType {
-    return typeName ? typeMap[typeName] : null;
+    return typeName != null ? typeMap[typeName] : null;
   }
 
   function getMergedDirectives(): Array<GraphQLDirective> {

Diff for: src/utilities/findDeprecatedUsages.js

@@ -34,7 +34,7 @@ export function findDeprecatedUsages(
             errors.push(
               new GraphQLError(
                 `The field "${parentType.name}.${fieldDef.name}" is deprecated.` +
-                  (reason ? ' ' + reason : ''),
+                  (reason != null ? ' ' + reason : ''),
                 node,
               ),
             );
@@ -50,7 +50,7 @@ export function findDeprecatedUsages(
             errors.push(
               new GraphQLError(
                 `The enum value "${type.name}.${enumVal.name}" is deprecated.` +
-                  (reason ? ' ' + reason : ''),
+                  (reason != null && reason !== '' ? ' ' + reason : ''),
                 node,
               ),
             );

Diff for: src/utilities/getOperationAST.js

@@ -18,7 +18,7 @@ export function getOperationAST(
   let operation = null;
   for (const definition of documentAST.definitions) {
     if (definition.kind === Kind.OPERATION_DEFINITION) {
-      if (!operationName) {
+      if (operationName == null) {
         // If no operation name was provided, only return an Operation if there
         // is one defined in the document. Upon encountering the second, return
         // null.