Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe check Schema for Graphene v3 #52

Closed
KingDarBoja opened this issue Jul 11, 2020 · 1 comment
Closed

Safe check Schema for Graphene v3 #52

KingDarBoja opened this issue Jul 11, 2020 · 1 comment
Assignees
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@KingDarBoja
Copy link
Contributor

KingDarBoja commented Jul 11, 2020

While testing locally the new server-core, I noticed I had to do this on my schema:

graphql-server-flask

Notice the graphql_schema part, I don't remember having to use it but since we assert on run_http_query function that it MUST be a GraphQLSchema, now we are forced to use the attribute graphql_schema of the Schema type.

@jkimbo suggested at the Slack channel to add a little compatibility layer to ensure it will work for both cases:

if not a graphql-core schema class then check if the object has an attribute called graphql_schema and use that instead.

This issue was made as remainder.

@KingDarBoja KingDarBoja added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jul 11, 2020
@KingDarBoja KingDarBoja self-assigned this Jul 11, 2020
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
@KingDarBoja
Copy link
Contributor Author

Closing as fixed at #54 by adding a note at each server integration regarding this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

No branches or pull requests

1 participant