Skip to content

Commit

Permalink
Remove Python 3.8 support (#525)
Browse files Browse the repository at this point in the history
  • Loading branch information
leszekhanusz authored Jan 27, 2025
1 parent ba61920 commit 996a2ad
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.10"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.10"]
os: [ubuntu-24.04, windows-latest]
exclude:
- os: windows-latest
Expand All @@ -20,8 +20,6 @@ jobs:
python-version: "3.10"
- os: windows-latest
python-version: "3.11"
- os: windows-latest
python-version: "3.12"
- os: windows-latest
python-version: "3.13"
- os: windows-latest
Expand Down
4 changes: 1 addition & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
"pytest-asyncio==0.21.1",
"pytest-console-scripts==1.4.1",
"pytest-cov==5.0.0",
"vcrpy==4.4.0;python_version<='3.8'",
"vcrpy==7.0.0;python_version>'3.8'",
"vcrpy==7.0.0",
"aiofiles",
]

Expand Down Expand Up @@ -86,7 +85,6 @@
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
3 changes: 0 additions & 3 deletions tests/test_websocket_online.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import asyncio
import logging
import sys
from typing import Dict

import pytest
Expand Down Expand Up @@ -151,7 +150,6 @@ async def test_websocket_sending_invalid_payload():


@pytest.mark.online
@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8 or higher")
@pytest.mark.skip(reason=skip_reason)
@pytest.mark.asyncio
async def test_websocket_sending_invalid_data_while_other_query_is_running():
Expand Down Expand Up @@ -203,7 +201,6 @@ async def query_task2():


@pytest.mark.online
@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8 or higher")
@pytest.mark.skip(reason=skip_reason)
@pytest.mark.asyncio
async def test_websocket_two_queries_in_parallel_using_two_tasks():
Expand Down
5 changes: 2 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
[tox]
envlist =
black,flake8,import-order,mypy,manifest,
py{38,39,310,311,312,313,py3}
py{39,310,311,312,313,py3}

[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
Expand All @@ -30,7 +29,7 @@ commands =
pip install -U setuptools
; run "tox -- tests -s" to show output for debugging
py{39,310,311,312,313,py3}: pytest {posargs:tests}
py{38}: pytest {posargs:tests --cov-report=term-missing --cov=gql}
py{312}: pytest {posargs:tests --cov-report=term-missing --cov=gql}

[testenv:black]
basepython = python
Expand Down

0 comments on commit 996a2ad

Please sign in to comment.