Skip to content

Commit 996a2ad

Browse files
authored
Remove Python 3.8 support (#525)
1 parent ba61920 commit 996a2ad

File tree

4 files changed

+4
-12
lines changed

4 files changed

+4
-12
lines changed

.github/workflows/tests.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
max-parallel: 4
1313
matrix:
14-
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.10"]
14+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.10"]
1515
os: [ubuntu-24.04, windows-latest]
1616
exclude:
1717
- os: windows-latest
@@ -20,8 +20,6 @@ jobs:
2020
python-version: "3.10"
2121
- os: windows-latest
2222
python-version: "3.11"
23-
- os: windows-latest
24-
python-version: "3.12"
2523
- os: windows-latest
2624
python-version: "3.13"
2725
- os: windows-latest

setup.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"pytest-asyncio==0.21.1",
2020
"pytest-console-scripts==1.4.1",
2121
"pytest-cov==5.0.0",
22-
"vcrpy==4.4.0;python_version<='3.8'",
23-
"vcrpy==7.0.0;python_version>'3.8'",
22+
"vcrpy==7.0.0",
2423
"aiofiles",
2524
]
2625

@@ -86,7 +85,6 @@
8685
"License :: OSI Approved :: MIT License",
8786
"Programming Language :: Python :: 3",
8887
"Programming Language :: Python :: 3 :: Only",
89-
"Programming Language :: Python :: 3.8",
9088
"Programming Language :: Python :: 3.9",
9189
"Programming Language :: Python :: 3.10",
9290
"Programming Language :: Python :: 3.11",

tests/test_websocket_online.py

-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import asyncio
22
import logging
3-
import sys
43
from typing import Dict
54

65
import pytest
@@ -151,7 +150,6 @@ async def test_websocket_sending_invalid_payload():
151150

152151

153152
@pytest.mark.online
154-
@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8 or higher")
155153
@pytest.mark.skip(reason=skip_reason)
156154
@pytest.mark.asyncio
157155
async def test_websocket_sending_invalid_data_while_other_query_is_running():
@@ -203,7 +201,6 @@ async def query_task2():
203201

204202

205203
@pytest.mark.online
206-
@pytest.mark.skipif(sys.version_info < (3, 8), reason="requires python3.8 or higher")
207204
@pytest.mark.skip(reason=skip_reason)
208205
@pytest.mark.asyncio
209206
async def test_websocket_two_queries_in_parallel_using_two_tasks():

tox.ini

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
[tox]
22
envlist =
33
black,flake8,import-order,mypy,manifest,
4-
py{38,39,310,311,312,313,py3}
4+
py{39,310,311,312,313,py3}
55

66
[gh-actions]
77
python =
8-
3.8: py38
98
3.9: py39
109
3.10: py310
1110
3.11: py311
@@ -30,7 +29,7 @@ commands =
3029
pip install -U setuptools
3130
; run "tox -- tests -s" to show output for debugging
3231
py{39,310,311,312,313,py3}: pytest {posargs:tests}
33-
py{38}: pytest {posargs:tests --cov-report=term-missing --cov=gql}
32+
py{312}: pytest {posargs:tests --cov-report=term-missing --cov=gql}
3433

3534
[testenv:black]
3635
basepython = python

0 commit comments

Comments
 (0)