Skip to content

Commit b54af7f

Browse files
feat: change loki_kafka_reader_receive_delay_seconds to gauge (#16864)
1 parent 07c9bcc commit b54af7f

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

pkg/kafka/partition/reader.go

+5-11
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package partition
33
import (
44
"context"
55
"fmt"
6-
"math"
76
"time"
87

98
"github.com/go-kit/log"
@@ -51,7 +50,7 @@ type ReaderMetrics struct {
5150
fetchesErrors prometheus.Counter
5251
fetchesTotal prometheus.Counter
5352
fetchWaitDuration prometheus.Histogram
54-
receiveDelay *prometheus.HistogramVec
53+
receiveDelay *prometheus.GaugeVec
5554
kprom *kprom.Metrics
5655
}
5756

@@ -75,14 +74,9 @@ func NewReaderMetrics(r prometheus.Registerer) *ReaderMetrics {
7574
Name: "loki_kafka_reader_fetches_total",
7675
Help: "Total number of Kafka fetches performed.",
7776
}),
78-
receiveDelay: promauto.With(r).NewHistogramVec(prometheus.HistogramOpts{
79-
Name: "loki_kafka_reader_receive_delay_seconds",
80-
Help: "Delay between producing a record and receiving it.",
81-
NativeHistogramZeroThreshold: math.Pow(2, -10),
82-
NativeHistogramBucketFactor: 1.2,
83-
NativeHistogramMaxBucketNumber: 100,
84-
NativeHistogramMinResetDuration: 1 * time.Hour,
85-
Buckets: prometheus.ExponentialBuckets(0.125, 2, 18),
77+
receiveDelay: promauto.With(r).NewGaugeVec(prometheus.GaugeOpts{
78+
Name: "loki_kafka_reader_receive_delay_seconds",
79+
Help: "Delay between producing a record and receiving it.",
8680
}, []string{"phase"}),
8781
kprom: client.NewReaderClientMetrics("partition-reader", r),
8882
}
@@ -152,7 +146,7 @@ func (r *KafkaReader) Poll(ctx context.Context, maxPollRecords int) ([]Record, e
152146
var numRecords int
153147
fetches.EachRecord(func(record *kgo.Record) {
154148
numRecords++
155-
r.metrics.receiveDelay.WithLabelValues(r.phase).Observe(time.Since(record.Timestamp).Seconds())
149+
r.metrics.receiveDelay.WithLabelValues(r.phase).Set(time.Since(record.Timestamp).Seconds())
156150
})
157151
r.metrics.recordsPerFetch.Observe(float64(numRecords))
158152

0 commit comments

Comments
 (0)