Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] node exporter is dropping wrong fstype #1319

Closed
dkpat12 opened this issue Mar 13, 2025 · 7 comments · Fixed by #1320 or #1327
Closed

[v2] node exporter is dropping wrong fstype #1319

dkpat12 opened this issue Mar 13, 2025 · 7 comments · Fixed by #1320 or #1327
Assignees
@petewall

Comments

@dkpat12
Copy link

dkpat12 commented Mar 13, 2025

I was digging into my Grafana Cloud metrics costs and noticed that this helm chart's node exporter deployment is dropping "tempfs". Shouldn't that be "tmpfs" instead?

https://github.com/grafana/k8s-monitoring-helm/blob/638cc2bccd51a63d8a5e0629df085c9942a43115/charts/k8s-monitoring/charts/feature-cluster-metrics/values.yaml#L628C9-L628C39
@petewall petewall self-assigned this Mar 13, 2025
@petewall
Copy link
Collaborator

Good catch! I'll get this fixed

@petewall petewall linked a pull request Mar 13, 2025 that will close this issue
Remove tmpfs and ramfs filesystems, not 'tempfs' #1320
Merged
@dkpat12
Copy link
Author

dkpat12 commented Mar 14, 2025

Thanks for the quick fix, @petewall ! Buuuut... I dug more today after I made this change on my usage of the chart and noticed the tmpfs filesystems were still reporting in to Grafana Cloud. That led me back deeper and.. Well I'm pretty confident this value isn't actually being used anywhere.

I searched the codebase for dropMetricsForFilesystem and did not find it being referenced within the v2 charts. I did find a reference to it within the v1 codebase But within the v2 chart it seems that was dropped. I think metrics.alloy is the equivalent in v2 which looks hardcoded to the string "tempfs"

@dkpat12
Copy link
Author

dkpat12 commented Mar 14, 2025

Quick update: I manually modified the grafana-k8s-monitoring-alloy-module-system configmap on my cluster to change the hardcoded "tempfs" in that to "tmpfs" and can confirm doing so did cause the metrics to stop reporting in to Grafana cloud.

@petewall
Copy link
Collaborator

🤦🏻

@petewall petewall reopened this Mar 14, 2025
@petewall
Copy link
Collaborator

I'll get this fixed.

@petewall
Copy link
Collaborator

For real this time!

@petewall petewall linked a pull request Mar 15, 2025 that will close this issue
Remove the Node Exporter module and fix filesystem exclusion #1327
Merged
@petewall
Copy link
Collaborator

Fixed in https://github.com/grafana/k8s-monitoring-helm/releases/tag/v2.0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petewall petewall

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petewall @dkpat12