Skip to content

Commit 7ef042a

Browse files
authored
Disable revive:use-errors-new linter (#685)
Disable revive:use-errors-new linter, as it requires too many changes to the codebase for now. Also ignore two other linter errors that have cropped up.
1 parent 3ce6164 commit 7ef042a

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

.golangci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ linters-settings:
9494
disabled: true
9595
- name: nested-structs
9696
disabled: true
97+
- name: use-errors-new
98+
disabled: true
9799
gocognit:
98100
min-complexity: 50
99101
mnd:

operator/reconciler.go

+2
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,8 @@ const (
154154
// - If the action is a Create, and the OpinionatedReconciler's finalizer is missing, add the finalizer after the delegated Reconcile request returns successfully
155155
// - If the action is an Update, and the DeletionTimestamp is non-nil, remove the OpinionatedReconciler's finalizer, and do not delegate (the subsequent Delete will be delegated)
156156
// - If the action is an Update, and the OpinionatedReconciler's finalizer is missing (and DeletionTimestamp is nil), add the finalizer, and do not delegate (the subsequent update action will delegate)
157+
//
158+
//nolint:funlen
157159
func (o *OpinionatedReconciler) Reconcile(ctx context.Context, request ReconcileRequest) (ReconcileResult, error) {
158160
ctx, span := GetTracer().Start(ctx, "OpinionatedReconciler-reconcile")
159161
defer span.End()

operator/runner.go

+1
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ func (s *Runner) Run(ctx context.Context, provider app.Provider) error {
225225
return runner.Run(ctx)
226226
}
227227

228+
//nolint:revive
228229
func (s *Runner) getManifestData(provider app.Provider) (*app.ManifestData, error) {
229230
manifest := provider.Manifest()
230231
data := app.ManifestData{}

0 commit comments

Comments
 (0)