Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] No desktop icon #135

Open
bootsa opened this issue Jul 16, 2019 · 7 comments
Open

[Linux] No desktop icon #135

bootsa opened this issue Jul 16, 2019 · 7 comments
Labels
linux Linux

Comments

@bootsa
Copy link

bootsa commented Jul 16, 2019

Desktop icon is not included/shown in Desktop Environment.
In panel chooser:
image
Or in task switcher:
image

Linux Mint Cinnamon 19.1 (Tessa)

@juancarlosfarah
Copy link
Member

Thanks for the feedback @bootsa! In the Ubuntu environment used to test the app, I do see the icon. May I ask how you installed the app?

@juancarlosfarah juancarlosfarah added the linux Linux label Jul 18, 2019
@bootsa
Copy link
Author

bootsa commented Jul 24, 2019

Sorry for the slow response.

I was running it straight from source as I had issues running the Snap image (see #143).

The AppImage build works but is also missing the icons.

It should still produce an icon even when run from source, correct?

There seems to be a few potential reasons for it:

I'm seeing the same issue with a clean built Electron app. Will investigate further when I have the chance - though I guess this is a lower priority issue.

Are you seeing the correct icon @NunonuN?

@bootsa
Copy link
Author

bootsa commented Jul 24, 2019

Interestingly when opening the about window as fixed by @pyphilia the icon shows up for that window but not the main window (in both the dock and the tab switcher):
image
image
It looks like because About Window sets the BrowserWindow's icon option...

bootsa added a commit to bootsa/graasp-desktop that referenced this issue Jul 24, 2019
Renders the app icon in the dock and task switcher.

Fixes graasp#135
@bootsa
Copy link
Author

bootsa commented Jul 24, 2019

Yep, simple as including icon: ICON_PATH in BrowserWindow options.

The image quality is rather poor when shown in the task switcher:

image

(I think the VS Code icon beside the Graasp icon is 1024 x 1024)

@juancarlosfarah
Copy link
Member

@bootsa, thanks for investigating. Normally running using yarn start does not show the icon. However, running a built image should show the right icon. The low resolution seems weird, as in Ubuntu it looks fine. Let's try and get feedback from @NunonuN. @porduna, you also were able to install the app on Linux. Do you have any feedback you could give us?

@porduna
Copy link

porduna commented Jul 24, 2019

Using the AppImage version, same icon issue, as well as in GNOME no option to add icon to favorites, etc.; however I guess that for desktop integration, I should install appimaged or AppImageLauncher according to https://docs.appimage.org/user-guide/run-appimages.html

image

@bootsa
Copy link
Author

bootsa commented Jul 26, 2019

The weird thing is that in the About window the icon comes out perfectly and is a lot larger than the task switcher version.
image

On a HiDpi laptop screen that's automatically double scaled but same happens with no scaling (probably not apparent here):
image

OS: Linux Mint Cinnamon 19.1 Tessa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux Linux
Projects
None yet
Development

No branches or pull requests

3 participants