fix: rename version to node-version, as using --version will log out versions of Node, Octokit, and the script (#4)

BREAKING CHANGE: `version` is now `node-version` as is now a required argument

Author: gr2m

.github/workflows/release.yml

@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: lts/*
       - uses: actions/cache@v2
         with:
           path: ~/.npm

.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node_version: ["12", "14"]
+        node_version: ["14", "16", "18"]
 
     steps:
       - uses: actions/checkout@v2

README.md

@@ -21,7 +21,7 @@ Pass all options as CLI flags to avoid user prompts
 npx octoherd-script-bump-node-version-in-workflows \
   -T ghp_0123456789abcdefghjklmnopqrstuvwxyzA \
   -R "gr2m/*" \
-  --version 16 \
+  --node-version 16 \
   --workflow release.yml
 ```
 
@@ -35,7 +35,7 @@ I run the script against all [@octokit repositories](https://github.com/orgs/oct
 
 | option                       | type             | description                                                                                                                                                                                                                                 |
 | ---------------------------- | ---------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `--version`                  | number           | Defaults to latest Node LTS major version (v16). You can set it to [`lts/*`](https://github.com/actions/setup-node#supported-version-syntax) to always get the latest LTS version if you prefer                                             |
+| `--node-version`             | number           | **Required** May be set to `lts/*`. See [all supported versions](https://github.com/actions/setup-node#supported-version-syntax)                                                                                                            |
 | `--workflow`                 | string           | workflow file name or pattern to only update a subset of workflows. [matcher](https://github.com/sindresorhus/matcher#usage) is used for matching. Defaults to `*`                                                                          |
 | `--octoherd-token`, `-T`     | string           | A personal access token ([create](https://github.com/settings/tokens/new?scopes=repo)). Script will create one if option is not set                                                                                                         |
 | `--octoherd-repos`, `-R`     | array of strings | One or multiple space-separated repositories in the form of `repo-owner/repo-name`. `repo-owner/*` will find all repositories for one owner. `*` will find all repositories the user has access to. Will prompt for repositories if not set |

script.js

@@ -10,14 +10,17 @@ import yaml from "js-yaml";
  * @param {import('@octoherd/cli').Octokit} octokit
  * @param {import('@octoherd/cli').Repository} repository
  * @param {object} options
- * @param {number} [options.version] Defaults to latest Node LTS major version
+ * @param {number | string} [options.nodeVersion] Defaults to latest Node LTS major version
  * @param {string} [options.workflow] workflow file name or pattern to only update a subset of workflows
  */
 export async function script(
   octokit,
   repository,
-  { version = 16, workflow = "*" }
+  { nodeVersion = "", workflow = "*" }
 ) {
+  if (!nodeVersion) {
+    throw new Error(`--node-version is required`);
+  }
   if (repository.archived) {
     octokit.log.info(`Repository is archived, ignoring`);
     return;
@@ -82,7 +85,7 @@ export async function script(
           return content;
         }
 
-        if (!config.jobs) {
+        if (!config?.jobs) {
           octokit.log.warn(`No jobs in ${name}`);
           return content;
         }
@@ -105,10 +108,10 @@ export async function script(
                 }
               }
 
-              if (Number(step.with["node-version"]) === version) continue;
+              if (Number(step.with["node-version"]) === nodeVersion) continue;
               if (String(step.with["node-version"]).includes("${{")) continue;
 
-              step.with["node-version"] = version;
+              step.with["node-version"] = nodeVersion;
               nodeVersionChanged = true;
             }
           }
@@ -120,7 +123,7 @@ export async function script(
           quotingType: '"',
         });
       },
-      message: `build(${name}): set node-version to ${version}`,
+      message: `build(${name}): set node-version to ${nodeVersion}`,
     });
 
     if (updated) {