Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit 1d8c6e0

Browse files
tall-nutsgaopengfei
and
gaopengfei
authored
Add the @IntRange annotation to requestCode to prevent invalid input (#325)
Co-authored-by: gaopengfei <[email protected]>
1 parent 8952eac commit 1d8c6e0

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

easypermissions/src/main/java/pub/devrel/easypermissions/EasyPermissions.java

+4-5
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,17 @@
2020
import android.content.Context;
2121
import android.content.pm.PackageManager;
2222
import android.os.Build;
23+
import androidx.annotation.IntRange;
2324
import androidx.annotation.NonNull;
2425
import androidx.annotation.Size;
2526
import androidx.core.app.ActivityCompat;
2627
import androidx.fragment.app.Fragment;
2728
import androidx.core.content.ContextCompat;
2829
import android.util.Log;
29-
3030
import java.lang.reflect.InvocationTargetException;
3131
import java.lang.reflect.Method;
3232
import java.util.ArrayList;
3333
import java.util.List;
34-
3534
import pub.devrel.easypermissions.helper.PermissionHelper;
3635

3736
/**
@@ -108,7 +107,7 @@ public static boolean hasPermissions(@NonNull Context context,
108107
*/
109108
public static void requestPermissions(
110109
@NonNull Activity host, @NonNull String rationale,
111-
int requestCode, @Size(min = 1) @NonNull String... perms) {
110+
@IntRange(from = 0, to = 255) int requestCode, @Size(min = 1) @NonNull String... perms) {
112111
requestPermissions(
113112
new PermissionRequest.Builder(host, requestCode, perms)
114113
.setRationale(rationale)
@@ -122,7 +121,7 @@ public static void requestPermissions(
122121
*/
123122
public static void requestPermissions(
124123
@NonNull Fragment host, @NonNull String rationale,
125-
int requestCode, @Size(min = 1) @NonNull String... perms) {
124+
@IntRange(from = 0, to = 255) int requestCode, @Size(min = 1) @NonNull String... perms) {
126125
requestPermissions(
127126
new PermissionRequest.Builder(host, requestCode, perms)
128127
.setRationale(rationale)
@@ -169,7 +168,7 @@ public static void requestPermissions(PermissionRequest request) {
169168
* @param receivers an array of objects that have a method annotated with {@link
170169
* AfterPermissionGranted} or implement {@link PermissionCallbacks}.
171170
*/
172-
public static void onRequestPermissionsResult(int requestCode,
171+
public static void onRequestPermissionsResult(@IntRange(from = 0, to = 255) int requestCode,
173172
@NonNull String[] permissions,
174173
@NonNull int[] grantResults,
175174
@NonNull Object... receivers) {

0 commit comments

Comments
 (0)