Zoom in/out with shortcut misbehaves on key repeat

[justvanrossum]

It will zoom the entire UI, which can mess up everything.

This may be a general problem with actions, but I'm not sure yet where exactly this needs to be fixed.

This happens both in the editor and in the font overview.

[qwerasd205]

It seems that all repeated keys are thrown out in the shortcut handling.

fontra/src/fontra/client/core/actions.js

Lines 196 to 199 in 3b200e3

	export function getActionIdentifierFromKeyEvent(event) {
	if (event.repeat) {
	return null;
	}

This is especially bad with the undo shortcut in Safari, since when it's thrown out it doesn't preventDefault, which causes Safari to receive the event, and Safari's behavior is to open recently closed tabs.

Luckily this should be an easy fix, though there may be a good reason for throwing out repeated events that I'm not aware of. If some key combos should only happen once even with held keys then perhaps it should be configured per shortcut whether repeated events are consumed silently or respected.