Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showcase samples should be part of golden tests #2470

Open
zhumin8 opened this issue Feb 13, 2024 · 5 comments · May be fixed by #3568
Open

showcase samples should be part of golden tests #2470

zhumin8 opened this issue Feb 13, 2024 · 5 comments · May be fixed by #3568
Assignees
@diegomarquezp
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Feb 13, 2024

sample snippets here should be part of the golden testing for Showcase.

Steps to identify this:

rm -rf showcase/gapic-showcase/samples/
mvn clean install -DskipTests
cd showcase

then mvn compile -P update, expect the samples should be re-generated and added back.
But this samples folder is not re-generated
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 13, 2024
@lqiu96 lqiu96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 15, 2024
@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 4, 2024
@blakeli0
Copy link
Collaborator

blakeli0 commented Mar 4, 2024

I think it worked before, could it be an issue caused by migrating Showcase to the hermetic build scrips? cc: @diegomarquezp @JoeWang1127

@JoeWang1127
Copy link
Collaborator

Probably because we didn't copy sample directory in https://github.com/googleapis/sdk-platform-java/blob/main/showcase/scripts/generate_components.sh

@blakeli0 blakeli0 removed the priority: p3 Desirable enhancement or fix. May not be included in next release. label Mar 4, 2024
@lqiu96
Copy link
Contributor

lqiu96 commented May 21, 2024

Keeping this a P2 issue. Seems to be due to a regression in the hermetic build scripts.

@blakeli0
Copy link
Collaborator

blakeli0 commented Aug 6, 2024

This was done in the early phase of hermetic build when we didn't have the image. We should migrate the showcase module to use hermetic build image now, with a dedicated generation_config.yaml.

@JoeWang1127 JoeWang1127 self-assigned this Aug 23, 2024
@diegomarquezp diegomarquezp linked a pull request Jan 14, 2025 that will close this issue
Open
@diegomarquezp
Copy link
Contributor

#3568 uses the docker image and generates samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegomarquezp diegomarquezp

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generate showcase using docker image googleapis/sdk-platform-java
5 participants
@zhumin8 @blakeli0 @lqiu96 @diegomarquezp @JoeWang1127