Skip to content

Commit b6563db

Browse files
TCMalloc Teamcopybara-github
TCMalloc Team
authored andcommitted
Add support for --incompatible_config_setting_private_default_visibility
bazelbuild/bazel#12933 indicates this is an older flag, from 2021. But I ran into this with `bazelisk --migrate` (https://github.com/bazelbuild/bazelisk#--migrate) and thought it'd be nice to support it. PiperOrigin-RevId: 712990438 Change-Id: Ie0282401b44d505e2e34117b1d1dc22aa3380c02
1 parent f852823 commit b6563db

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.bazelrc

+5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ build --cxxopt='-std=c++17'
1818
# https://github.com/bazelbuild/bazel/pull/15327 for details.
1919
build --incompatible_disallow_empty_glob
2020

21+
# Flip incompatible_config_setting_private_default_visibility to avoid breaking
22+
# forward compatibility. See https://github.com/bazelbuild/bazel/issues/12933
23+
# for details.
24+
common --incompatible_config_setting_private_default_visibility
25+
2126
# Link Google Test against Abseil and RE2.
2227
build --define='absl=1'
2328

tcmalloc/BUILD

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ config_setting(
3232
flag_values = {
3333
"@bazel_tools//tools/cpp:compiler": "clang",
3434
},
35+
visibility = ["//tcmalloc:__subpackages__"],
3536
)
3637

3738
cc_library(

0 commit comments

Comments
 (0)