diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 325f6b538..f4682a3ce 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -1,4 +1,4 @@ -# Created with package:mono_repo v6.5.7 +# Created with package:mono_repo v6.6.1 name: Dart CI on: push: @@ -35,18 +35,18 @@ jobs: name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - name: mono_repo self validate - run: dart pub global activate mono_repo 6.5.7 + run: dart pub global activate mono_repo 6.6.1 - name: mono_repo self validate run: dart pub global run mono_repo generate --validate job_002: - name: "format_analyze; linux; Dart 2.19.0; PKG: protobuf; `dart analyze lib`, `dart analyze test`" + name: "format_analyze_test; linux; Dart 2.19.0; PKG: protobuf; `dart analyze --fatal-infos`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:analyze_1-analyze_2" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:analyze_0" restore-keys: | os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 @@ -64,143 +64,127 @@ jobs: run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" working-directory: protobuf - - name: protobuf; dart analyze lib - run: dart analyze lib - if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" - working-directory: protobuf - - name: protobuf; dart analyze test - run: dart analyze test + - name: "protobuf; dart analyze --fatal-infos" + run: dart analyze --fatal-infos if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" working-directory: protobuf job_003: - name: "format_analyze; linux; Dart dev; PKG: api_benchmark; `dart format --output=none --set-exit-if-changed .`, `./../tool/setup.sh`, `./compile_protos.sh`, `dart analyze --fatal-infos`" + name: "format_analyze_test; linux; Dart 2.19.0; PKG: protobuf; `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:api_benchmark;commands:format-command_0-command_1-analyze_0" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:test_0" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:api_benchmark - os:ubuntu-latest;pub-cache-hosted;sdk:dev + os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf + os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - name: Setup Dart SDK uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 with: - sdk: dev + sdk: "2.19.0" - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - - id: api_benchmark_pub_upgrade - name: api_benchmark; dart pub upgrade + - id: protobuf_pub_upgrade + name: protobuf; dart pub upgrade run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: api_benchmark - - name: "api_benchmark; dart format --output=none --set-exit-if-changed ." - run: "dart format --output=none --set-exit-if-changed ." - if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" - working-directory: api_benchmark - - name: api_benchmark; ./../tool/setup.sh - run: ./../tool/setup.sh - if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" - working-directory: api_benchmark - - name: api_benchmark; ./compile_protos.sh - run: ./compile_protos.sh - if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" - working-directory: api_benchmark - - name: "api_benchmark; dart analyze --fatal-infos" - run: dart analyze --fatal-infos - if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" - working-directory: api_benchmark + working-directory: protobuf + - name: protobuf; dart test + run: dart test + if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" + working-directory: protobuf job_004: - name: "format_analyze; linux; Dart dev; PKG: benchmarks; `dart format --output=none --set-exit-if-changed .`, `./../tool/setup.sh`, `./tool/compile_protos.sh`, `dart analyze --fatal-infos`" + name: "format_analyze_test; linux; Dart 2.19.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test legacy_tests/generated_message_test.dart`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:benchmarks;commands:format-command_0-command_2-analyze_0" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin;commands:command_0-command_3-test_1" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:benchmarks - os:ubuntu-latest;pub-cache-hosted;sdk:dev + os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin + os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - name: Setup Dart SDK uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 with: - sdk: dev + sdk: "2.19.0" - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - - id: benchmarks_pub_upgrade - name: benchmarks; dart pub upgrade + - id: protoc_plugin_pub_upgrade + name: protoc_plugin; dart pub upgrade run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: benchmarks - - name: "benchmarks; dart format --output=none --set-exit-if-changed ." - run: "dart format --output=none --set-exit-if-changed ." - if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" - working-directory: benchmarks - - name: benchmarks; ./../tool/setup.sh + working-directory: protoc_plugin + - name: protoc_plugin; ./../tool/setup.sh run: ./../tool/setup.sh - if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" - working-directory: benchmarks - - name: benchmarks; ./tool/compile_protos.sh - run: ./tool/compile_protos.sh - if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" - working-directory: benchmarks - - name: "benchmarks; dart analyze --fatal-infos" - run: dart analyze --fatal-infos - if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" - working-directory: benchmarks + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin + - name: protoc_plugin; make protos + run: make protos + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin + - name: protoc_plugin; dart test legacy_tests/generated_message_test.dart + run: dart test legacy_tests/generated_message_test.dart + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin job_005: - name: "format_analyze; linux; Dart dev; PKG: protobuf; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos`" + name: "format_analyze_test; linux; Dart 2.19.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:format-analyze_0" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin;commands:command_0-command_3-test_0" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf - os:ubuntu-latest;pub-cache-hosted;sdk:dev + os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin + os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - name: Setup Dart SDK uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 with: - sdk: dev + sdk: "2.19.0" - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - - id: protobuf_pub_upgrade - name: protobuf; dart pub upgrade + - id: protoc_plugin_pub_upgrade + name: protoc_plugin; dart pub upgrade run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: protobuf - - name: "protobuf; dart format --output=none --set-exit-if-changed ." - run: "dart format --output=none --set-exit-if-changed ." - if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" - working-directory: protobuf - - name: "protobuf; dart analyze --fatal-infos" - run: dart analyze --fatal-infos - if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" - working-directory: protobuf + working-directory: protoc_plugin + - name: protoc_plugin; ./../tool/setup.sh + run: ./../tool/setup.sh + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin + - name: protoc_plugin; make protos + run: make protos + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin + - name: protoc_plugin; dart test + run: dart test + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin job_006: - name: "format_analyze; linux; Dart dev; PKG: protoc_plugin; `dart format --output=none --set-exit-if-changed .`, `./../tool/setup.sh`, `make protos`, `dart analyze --fatal-infos bin lib test`" + name: "format_analyze_test; linux; Dart dev; PKG: protobuf; `dart analyze --fatal-infos`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin;commands:format-command_0-command_3-analyze_3" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:analyze_0" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin + os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf os:ubuntu-latest;pub-cache-hosted;sdk:dev os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest @@ -211,45 +195,33 @@ jobs: - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - - id: protoc_plugin_pub_upgrade - name: protoc_plugin; dart pub upgrade + - id: protobuf_pub_upgrade + name: protobuf; dart pub upgrade run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: protoc_plugin - - name: "protoc_plugin; dart format --output=none --set-exit-if-changed ." - run: "dart format --output=none --set-exit-if-changed ." - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin - - name: protoc_plugin; ./../tool/setup.sh - run: ./../tool/setup.sh - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin - - name: protoc_plugin; make protos - run: make protos - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin - - name: "protoc_plugin; dart analyze --fatal-infos bin lib test" - run: dart analyze --fatal-infos bin lib test - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin + working-directory: protobuf + - name: "protobuf; dart analyze --fatal-infos" + run: dart analyze --fatal-infos + if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" + working-directory: protobuf job_007: - name: "run_tests; linux; Dart 2.19.0; PKG: protobuf; `dart test`" + name: "format_analyze_test; linux; Dart dev; PKG: protobuf; `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:test_0" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:test_0" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf - os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 + os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf + os:ubuntu-latest;pub-cache-hosted;sdk:dev os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - name: Setup Dart SDK uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 with: - sdk: "2.19.0" + sdk: dev - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 @@ -262,31 +234,24 @@ jobs: run: dart test if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" working-directory: protobuf - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 job_008: - name: "run_tests; linux; Dart 2.19.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`" + name: "format_analyze_test; linux; Dart dev; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin;commands:command_0-command_3-test_0" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin;commands:command_0-command_3-test_0" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin - os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 + os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin + os:ubuntu-latest;pub-cache-hosted;sdk:dev os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - name: Setup Dart SDK uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 with: - sdk: "2.19.0" + sdk: dev - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 @@ -307,59 +272,15 @@ jobs: run: dart test if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" working-directory: protoc_plugin - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 job_009: - name: "run_tests; linux; Dart dev; PKG: protobuf; `dart test`" + name: "format_analyze_test; linux; Dart dev; PKG: protoc_plugin; `dart format --output=none --set-exit-if-changed .`, `./../tool/setup.sh`, `make protos`, `dart analyze --fatal-infos bin lib test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf;commands:test_0" - restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protobuf - os:ubuntu-latest;pub-cache-hosted;sdk:dev - os:ubuntu-latest;pub-cache-hosted - os:ubuntu-latest - - name: Setup Dart SDK - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 - with: - sdk: dev - - id: checkout - name: Checkout repository - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - - id: protobuf_pub_upgrade - name: protobuf; dart pub upgrade - run: dart pub upgrade - if: "always() && steps.checkout.conclusion == 'success'" - working-directory: protobuf - - name: protobuf; dart test - run: dart test - if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" - working-directory: protobuf - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 - job_010: - name: "run_tests; linux; Dart dev; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`" - runs-on: ubuntu-latest - steps: - - name: Cache Pub hosted dependencies - uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 - with: - path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin;commands:command_0-command_3-test_0" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin;commands:format-command_0-command_3-analyze_1" restore-keys: | os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:protoc_plugin os:ubuntu-latest;pub-cache-hosted;sdk:dev @@ -377,6 +298,10 @@ jobs: run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" working-directory: protoc_plugin + - name: "protoc_plugin; dart format --output=none --set-exit-if-changed ." + run: "dart format --output=none --set-exit-if-changed ." + if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" + working-directory: protoc_plugin - name: protoc_plugin; ./../tool/setup.sh run: ./../tool/setup.sh if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" @@ -385,19 +310,12 @@ jobs: run: make protos if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" working-directory: protoc_plugin - - name: protoc_plugin; dart test - run: dart test + - name: "protoc_plugin; dart analyze --fatal-infos bin lib test" + run: dart analyze --fatal-infos bin lib test if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" working-directory: protoc_plugin - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 - job_011: - name: "run_tests; osx; Dart 2.19.0; PKG: protobuf; `dart test`" + job_010: + name: "format_analyze_test; osx; Dart 2.19.0; PKG: protobuf; `dart test`" runs-on: macos-latest steps: - name: Cache Pub hosted dependencies @@ -426,15 +344,8 @@ jobs: run: dart test if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" working-directory: protobuf - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 - job_012: - name: "run_tests; osx; Dart dev; PKG: protobuf; `dart test`" + job_011: + name: "format_analyze_test; osx; Dart dev; PKG: protobuf; `dart test`" runs-on: macos-latest steps: - name: Cache Pub hosted dependencies @@ -463,15 +374,8 @@ jobs: run: dart test if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" working-directory: protobuf - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 - job_013: - name: "run_tests; windows; Dart 2.19.0; PKG: protobuf; `dart test`" + job_012: + name: "format_analyze_test; windows; Dart 2.19.0; PKG: protobuf; `dart test`" runs-on: windows-latest steps: - name: Setup Dart SDK @@ -490,15 +394,8 @@ jobs: run: dart test if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" working-directory: protobuf - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 - job_014: - name: "run_tests; windows; Dart dev; PKG: protobuf; `dart test`" + job_013: + name: "format_analyze_test; windows; Dart dev; PKG: protobuf; `dart test`" runs-on: windows-latest steps: - name: Setup Dart SDK @@ -517,6 +414,48 @@ jobs: run: dart test if: "always() && steps.protobuf_pub_upgrade.conclusion == 'success'" working-directory: protobuf + job_014: + name: "format_analyze; linux; Dart dev; PKG: api_benchmark; `dart format --output=none --set-exit-if-changed .`, `./../tool/setup.sh`, `./compile_protos.sh`, `dart analyze --fatal-infos`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:api_benchmark;commands:format-command_0-command_1-analyze_0" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:api_benchmark + os:ubuntu-latest;pub-cache-hosted;sdk:dev + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - name: Setup Dart SDK + uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 + with: + sdk: dev + - id: checkout + name: Checkout repository + uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 + - id: api_benchmark_pub_upgrade + name: api_benchmark; dart pub upgrade + run: dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: api_benchmark + - name: "api_benchmark; dart format --output=none --set-exit-if-changed ." + run: "dart format --output=none --set-exit-if-changed ." + if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" + working-directory: api_benchmark + - name: api_benchmark; ./../tool/setup.sh + run: ./../tool/setup.sh + if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" + working-directory: api_benchmark + - name: api_benchmark; ./compile_protos.sh + run: ./compile_protos.sh + if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" + working-directory: api_benchmark + - name: "api_benchmark; dart analyze --fatal-infos" + run: dart analyze --fatal-infos + if: "always() && steps.api_benchmark_pub_upgrade.conclusion == 'success'" + working-directory: api_benchmark needs: - job_001 - job_002 @@ -524,44 +463,55 @@ jobs: - job_004 - job_005 - job_006 + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 job_015: - name: "run_legacy_tests; linux; Dart 2.19.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test legacy_tests/generated_message_test.dart`" + name: "format_analyze; linux; Dart dev; PKG: benchmarks; `dart format --output=none --set-exit-if-changed .`, `./../tool/setup.sh`, `./tool/compile_protos.sh`, `dart analyze --fatal-infos`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin;commands:command_0-command_3-test_1" + key: "os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:benchmarks;commands:format-command_0-command_2-analyze_0" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin - os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0 + os:ubuntu-latest;pub-cache-hosted;sdk:dev;packages:benchmarks + os:ubuntu-latest;pub-cache-hosted;sdk:dev os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - name: Setup Dart SDK uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 with: - sdk: "2.19.0" + sdk: dev - id: checkout name: Checkout repository uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - - id: protoc_plugin_pub_upgrade - name: protoc_plugin; dart pub upgrade + - id: benchmarks_pub_upgrade + name: benchmarks; dart pub upgrade run: dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: protoc_plugin - - name: protoc_plugin; ./../tool/setup.sh + working-directory: benchmarks + - name: "benchmarks; dart format --output=none --set-exit-if-changed ." + run: "dart format --output=none --set-exit-if-changed ." + if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" + working-directory: benchmarks + - name: benchmarks; ./../tool/setup.sh run: ./../tool/setup.sh - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin - - name: protoc_plugin; make protos - run: make protos - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin - - name: protoc_plugin; dart test legacy_tests/generated_message_test.dart - run: dart test legacy_tests/generated_message_test.dart - if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'" - working-directory: protoc_plugin + if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" + working-directory: benchmarks + - name: benchmarks; ./tool/compile_protos.sh + run: ./tool/compile_protos.sh + if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" + working-directory: benchmarks + - name: "benchmarks; dart analyze --fatal-infos" + run: dart analyze --fatal-infos + if: "always() && steps.benchmarks_pub_upgrade.conclusion == 'success'" + working-directory: benchmarks needs: - job_001 - job_002 @@ -576,4 +526,3 @@ jobs: - job_011 - job_012 - job_013 - - job_014 diff --git a/mono_repo.yaml b/mono_repo.yaml index 93f1d7860..d0a86960e 100644 --- a/mono_repo.yaml +++ b/mono_repo.yaml @@ -1,5 +1,5 @@ # See https://github.com/google/mono_repo.dart for details on this file -self_validate: format_analyze +self_validate: format_analyze_test github: on: @@ -10,7 +10,3 @@ github: branches: master schedule: - cron: "0 0 * * 0" - -merge_stages: -- format_analyze -- run_tests diff --git a/protobuf/mono_pkg.yaml b/protobuf/mono_pkg.yaml index 4d9ca7b6c..f493bd599 100644 --- a/protobuf/mono_pkg.yaml +++ b/protobuf/mono_pkg.yaml @@ -1,16 +1,26 @@ # See https://github.com/dart-lang/mono_repo for details stages: - - format_analyze: - - group: - - format - - analyze: --fatal-infos + - format_analyze_test: + + # Analyze with the dev version, but ignore failures. Warnings/infos in dev + # version may not be fixable with the latest stable, for example when the + # dev version deprecates a member and adds a replacement, the replacement + # may not be available in the latest stable. + # + # TODO: How do we ignore failures in this step (don't mark it as "failing" + # in GitHub)? + - analyze: --fatal-infos sdk: [dev] - - group: - - analyze: lib - - analyze: test + + - analyze: --fatal-infos sdk: [pubspec] - - run_tests: + + # TODO: Similar to above, dev tests should not mark the PR tests as "failing". + - group: [test] + sdk: [dev] + os: [linux, osx, windows] + - group: [test] - sdk: [pubspec, dev] + sdk: [pubspec] os: [linux, osx, windows] diff --git a/protoc_plugin/mono_pkg.yaml b/protoc_plugin/mono_pkg.yaml index f7cefe59b..8e06804f8 100644 --- a/protoc_plugin/mono_pkg.yaml +++ b/protoc_plugin/mono_pkg.yaml @@ -1,6 +1,6 @@ # See https://github.com/dart-lang/mono_repo for details stages: - - format_analyze: + - format_analyze_test: - group: - format - command: ./../tool/setup.sh @@ -8,13 +8,13 @@ stages: # Specify directores to exclude legacy_tests - analyze: --fatal-infos bin lib test sdk: [dev] - - run_tests: + - group: - command: ./../tool/setup.sh - command: make protos - test sdk: [pubspec, dev] - - run_legacy_tests: + - group: - command: ./../tool/setup.sh - command: make protos diff --git a/tool/ci.sh b/tool/ci.sh index a824f9d2b..05f458a60 100755 --- a/tool/ci.sh +++ b/tool/ci.sh @@ -1,9 +1,10 @@ #!/bin/bash -# Created with package:mono_repo v6.5.7 +# Created with package:mono_repo v6.6.1 # Support built in commands on windows out of the box. + # When it is a flutter repo (check the pubspec.yaml for "sdk: flutter") -# then "flutter" is called instead of "pub". +# then "flutter pub" is called instead of "dart pub". # This assumes that the Flutter SDK has been installed in a previous step. function pub() { if grep -Fq "sdk: flutter" "${PWD}/pubspec.yaml"; then @@ -12,18 +13,13 @@ function pub() { command dart pub "$@" fi } -# When it is a flutter repo (check the pubspec.yaml for "sdk: flutter") -# then "flutter" is called instead of "pub". -# This assumes that the Flutter SDK has been installed in a previous step. + function format() { - if grep -Fq "sdk: flutter" "${PWD}/pubspec.yaml"; then - command flutter format "$@" - else - command dart format "$@" - fi + command dart format "$@" } + # When it is a flutter repo (check the pubspec.yaml for "sdk: flutter") -# then "flutter" is called instead of "pub". +# then "flutter analyze" is called instead of "dart analyze". # This assumes that the Flutter SDK has been installed in a previous step. function analyze() { if grep -Fq "sdk: flutter" "${PWD}/pubspec.yaml"; then @@ -72,14 +68,6 @@ for PKG in ${PKGS}; do dart analyze --fatal-infos || EXIT_CODE=$? ;; analyze_1) - echo 'dart analyze lib' - dart analyze lib || EXIT_CODE=$? - ;; - analyze_2) - echo 'dart analyze test' - dart analyze test || EXIT_CODE=$? - ;; - analyze_3) echo 'dart analyze --fatal-infos bin lib test' dart analyze --fatal-infos bin lib test || EXIT_CODE=$? ;;