Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement package specifier #90

Closed
RdeWilde opened this issue Mar 18, 2018 · 4 comments
Closed

Implement package specifier #90

RdeWilde opened this issue Mar 18, 2018 · 4 comments
Labels
feature request

Comments

@RdeWilde
Copy link

Any way to implement the package option?

https://developers.google.com/protocol-buffers/docs/proto3#packages
sigurdm pushed a commit to sigurdm/protobuf that referenced this issue Dec 10, 2018
@jakobr-google
Update gRPC client stub generation. (google#90)
1aa5a41 
Client stubs should extend Client and use $createCall to create
ClientCall objects. The super-class will handle merging the per-client
call options with the per-RPC options. And make it easier to refactor
call generation code.
@kriswuollett kriswuollett mentioned this issue Jun 20, 2019
Open
@osa1 osa1 changed the title Implement option package Implement package specifier May 11, 2022
@osa1
Copy link
Member

osa1 commented May 11, 2022

I think we could generate library ...; lines for package specifiers in proto files. Any thoughts on this @sigurdm?

@sigurdm
Copy link
Collaborator

sigurdm commented May 16, 2022

library lines in dart has no semantic meaning (except if you are using dart:mirrors).

I think what this issue is really proposing is something like #295.

@RdeWilde is that true? What is your use-case? What issues are you seeing?

@RdeWilde
Copy link
Author

Too long ago for me, but dart_package sounds like the same thing yeah @sigurdm

@osa1
Copy link
Member

osa1 commented May 18, 2022

OK, thanks for the update. Closing this one in favor of #295 as that one has more details.

@osa1 osa1 closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RdeWilde @osa1 @sigurdm