Skip to content

Commit deb0c22

Browse files
authored
Rationalise test suite classes. (#1177)
ConscryptJava7Suite is obsolete, and we no longer use suites for anything but OpenJDK so merge ConscryptSuite into ConscryptOpenJdkSuite. Ultimately I aim to stop using suites. This is part of #1155 but splitting it out here to simplify that change.
1 parent 5daf264 commit deb0c22

File tree

4 files changed

+161
-344
lines changed

4 files changed

+161
-344
lines changed

common/src/test/java/org/conscrypt/ConscryptJava7Suite.java

-137
This file was deleted.

common/src/test/java/org/conscrypt/ConscryptSuite.java

-167
This file was deleted.

openjdk/build.gradle

+2-18
Original file line numberDiff line numberDiff line change
@@ -315,28 +315,12 @@ def addNativeJar(NativeBuildInfo nativeBuild) {
315315
publishing.publications.maven.artifact jarTask.get()
316316
}
317317

318-
319-
// TODO(prb) Still provide a mechanism for testing on Java 7?
320-
// Check which version
321-
//def javaError = new ByteArrayOutputStream()
322-
//exec {
323-
// executable test.executable
324-
// System.out.println("Running tests with java executable: " + test.executable + ".")
325-
// args = ['-version']
326-
// ignoreExitValue true
327-
// errorOutput = javaError
328-
//}
329-
//
330-
//def suiteClass = (javaError.toString() =~ /"1[.]7[.].*"/) ?
331-
// "org/conscrypt/ConscryptJava7Suite.class" : "org/conscrypt/ConscryptSuite.class";
332-
def suiteClass = "org/conscrypt/ConscryptSuite.class";
333-
334318
test {
335-
include suiteClass, "org/conscrypt/ConscryptOpenJdkSuite.class"
319+
include "org/conscrypt/ConscryptOpenJdkSuite.class"
336320
}
337321

338322
def testFdSocket = tasks.register("testFdSocket", Test) {
339-
include suiteClass, "org/conscrypt/ConscryptOpenJdkSuite.class"
323+
include "org/conscrypt/ConscryptOpenJdkSuite.class"
340324
InvokerHelper.setProperties(testLogging, test.testLogging.properties)
341325
systemProperties = test.systemProperties
342326
systemProperty "org.conscrypt.useEngineSocketByDefault", false

0 commit comments

Comments
 (0)