We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have several set*Metadata(...) and set*Tags(...) method in the source code.
set*Metadata(...)
set*Tags(...)
We should improve those methods by calling a validator for the metadata and tags property, for example.
metadata
tags
public function setMetadata(array $metadata = []) { // Validates the metadata $this->metadataValidator->validate($metadata); // Sets the metadata $this->metadata = $metadata; // Returns this instance return $this; }
So we should create a \Gomoob\WebSocket\Validator\MetadataValidator class and a \Gomoob\WebSocket\Validator\TagsValidator class.
\Gomoob\WebSocket\Validator\MetadataValidator
\Gomoob\WebSocket\Validator\TagsValidator
The text was updated successfully, but these errors were encountered:
bgaillard
No branches or pull requests
We have several
set*Metadata(...)
andset*Tags(...)
method in the source code.We should improve those methods by calling a validator for the
metadata
andtags
property, for example.So we should create a
\Gomoob\WebSocket\Validator\MetadataValidator
class and a\Gomoob\WebSocket\Validator\TagsValidator
class.The text was updated successfully, but these errors were encountered: