Add server side events to notify the clients #346
+161
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamirr
requested changes
Sep 30, 2024
server/src/sse.rs
Outdated
| @@ -0,0 +1,63 @@ | |||
| use std::sync::{Arc, Mutex}; | |||
| use actix_web_lab::sse; | |||
| use actix_web_lab::sse::Event; | |||
There was a problem hiding this comment.
Please fix those unused imports. Changes look fine otherwise, I’ll approve once this is fixed
There was a problem hiding this comment.
But the build fails without those 3?
There was a problem hiding this comment.
Sorry, the comment might’ve been placed on the wrong line. See the checks tab — it says which imports are unused (also not all code is formatted with cargo fmt, this too needs to be done)
There was a problem hiding this comment.
Code formatted and removed unused imports
Signed-off-by: Shivank Anchal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.