Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_multiple_eth_accounts from golem's concent acceptance tests is failing #999

Closed
dybi opened this issue Dec 5, 2018 · 4 comments
Closed
Assignees
Labels
bug _high_priority this has a high priority and should be handled ASAP payment use case 'force payment' use case
Milestone

Comments

@dybi
Copy link
Contributor

dybi commented Dec 5, 2018

to reproduce:
pytest scripts/concent_acceptance_tests/force_payment/test_payment.py::RequestorDoesntPayTestCase::test_multiple_eth_accounts on branch chore-update-concent-acceptance-test-after-sra-update (GM v2.17.0)

@dybi dybi added bug not in pivotal Not yet added as a task in any story in Pivotal payment use case 'force payment' use case labels Dec 5, 2018
@PaweuB
Copy link

PaweuB commented Dec 5, 2018

@PaweuB PaweuB removed the not in pivotal Not yet added as a task in any story in Pivotal label Dec 5, 2018
@dybi dybi added the _high_priority this has a high priority and should be handled ASAP label Dec 6, 2018
@pawelkisielewicz pawelkisielewicz self-assigned this Dec 7, 2018
@cameel
Copy link
Contributor

cameel commented Dec 7, 2018

So the problem is that Concent in UC5 allows the provider to submit acceptances for subtasks which should be paid from different Ethereum accounts belonging to the requestor while it should refuse the request? Wasn't it already fixed in #545?

@pawelkisielewicz
Copy link
Contributor

pawelkisielewicz commented Dec 10, 2018

I asked @dybi about it, it was unclear for me as well. In this case there is one provider with two different Ethereum accounts and one requestor. According to expected message in test code Concent should answer ServiceRefused. @cameel I can't see this case in table in #996 and assume that it is expected Concent's behavior

@pawelkisielewicz
Copy link
Contributor

pawelkisielewicz commented Dec 10, 2018

The problem is resolved after add commit 77c0fb41 chore-update-concent-acceptance-test-after-sra-update. The reason of bug was changing provider_ethereum_public_key's in task_to_compute, where this field is made as property instead of change in want_to_compute_task. I added test in Concent for this case as well in #1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug _high_priority this has a high priority and should be handled ASAP payment use case 'force payment' use case
Projects
None yet
Development

No branches or pull requests

5 participants