Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing Service extension #5 #872

Open
dybi opened this issue Oct 8, 2018 · 2 comments
Open

Signing Service extension #5 #872

dybi opened this issue Oct 8, 2018 · 2 comments
Labels
bankster Bankster and related features feature not in pivotal Not yet added as a task in any story in Pivotal

Comments

@dybi
Copy link
Contributor

dybi commented Oct 8, 2018

Signing Service should have daily limits for transactions sums.
If the sum of transaction exceeds WARNING_DAILY_THRESHOLD = 1000 GNTB, Signing Service should issue a warning.
If the sum of transaction exceeds MAXIMUM_DAILY_THRESHOLD = 10000 GNTB, Signing Service should stop signing transactions.

TBD:

  1. What kind of notification should be sent (email / warning in sentry/ print to console/ etc.)?

It should be sent via email

  1. What if the transaction to be signed would greatly exceed MAXIMUM_DAILY_THRESHOLD? Maybe there should be check:
if transaction_to_be_signed.cost + daily_costs_so_far > MAXIMUM_DAILY_THRESHOLD:
     refuse_transaction()

Yes, the check should be like above.

  1. Should Signing Service send any kind of notification when MAXIMUM_DAILY_THRESHOLD is exceeded? How, to whom?

Yes, via email.

  1. Should Signing Service store daily_costs_so_far somewhere in case it is restarted?

Yes, simple file storage should be sufficient.

This issue should be closed when: #873, #877 and #878 are implemented.

@dybi dybi added feature not in pivotal Not yet added as a task in any story in Pivotal bankster Bankster and related features labels Oct 8, 2018
@rwrzesien
Copy link
Contributor

rwrzesien commented Oct 8, 2018

Should Signing Service store daily_costs_so_far somewhere in case it is restarted?

@dybi dybi changed the title [WIP] Signing Service extension #5 Signing Service extension #5 Oct 10, 2018
@cameel
Copy link
Contributor

cameel commented Nov 26, 2018

So, what's the status of this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bankster Bankster and related features feature not in pivotal Not yet added as a task in any story in Pivotal
Projects
None yet
Development

No branches or pull requests

3 participants