Date Localization Issues with dayjs

[davide-ruota]

Description

Hi, I have some issues with date localization. I initially thought it was due to localization settings, but I realized it depends on the localization provided by dayjs.

I also checked on https://try.vikunja.io and noticed that other languages besides Italian have localization issues.
In practice, only German, French, and Russian are translated correctly, and maybe a few others (I haven't checked everything).

Vikunja Version

v0.24.1-657-8ba9ded3e2

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

[kolaente]

This seems to be a problem with our loading of these translations. The italian translation files seem correct. @dpschen Do you have an idea what could be wrong here?

[dpschen]

I would assume that the dayjs language mapping is the issue here, since it doesn't seem like it's in sync.

EDIT

Also SUPPORTED_LOCALES need to be updated accordingly. I thought that they would be up-to-date, but they don't seem to be?

[kolaente]

Crowdin syncs all languages, but only those with translated strings of more than 50% are added to SUPPORTED_LOCALES. That's why not all languages we have files for are included.

Italian is included correctly, but the date strings are not used?

[dpschen]

I see, will check further, thanks for clarification!

I wasn't aware that Crowdin also changed the SUPPORTED_LOCALES list. Maybe we should add a comment there. Or to make it even more obvious we could generate the list in an external file that gets imported in i18n/index.ts.

Why do we add json files of languages that have less than 50%?

[kolaente]

I wasn't aware that Crowdin also changed the SUPPORTED_LOCALES list

It doesn't, the crowdin sync will only create the files. Adding a language to SUPPORTED_LOCALES is a manual process.

Why do we add json files of languages that have less than 50%?

That's a limitation of the crowdin sync job.

[kolaente]

It looks like the part of Vikunja from the screenshot in the first comment does not use dayjs, but date-fns (a different library) 🙃

https://github.com/go-vikunja/vikunja/blob/main/frontend/src/helpers/time/formatDate.ts#L4-L5

Why again do we have two date libraries?

[kolaente]

PR is up: https://kolaente.dev/vikunja/vikunja/pulls/3039

[jon4god]

I think it's a pretty critical bug. I get everything related to dates in English, although I use Russian in v0.24.6. And besides I have other inserts from English, although everything is translated in Crowdin.

[kolaente]

And besides I have other inserts from English, although everything is translated in Crowdin.

Not all translated strings are approved. Only approved strings will show up in Vikunja.

[kolaente]

Fixed in 021d71b, please check with the next unstable build (should be ready for deployment in ~45min, also on try).

[jon4god]

From what I understand the changes can be viewed at https://try.vikunja.io/. Checked it out. There's still a problem with the dates.
Gone are the remnants of English from the settings.

[kolaente]

This seems to affect a handful of languages, but it's completely unclear to me why. Dayjs has all the required translations.