Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropped commit code and subtitle fonts #3578

Closed
1 of 3 tasks
inmylo opened this issue Feb 24, 2018 · 3 comments
Closed
1 of 3 tasks

Cropped commit code and subtitle fonts #3578

inmylo opened this issue Feb 24, 2018 · 3 comments
Labels
status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug

Comments

@inmylo
Copy link

inmylo commented Feb 24, 2018

Description

When I open commit details in Chromium browser I see that all code text and subtitle is cropped - no upper or bottom parts of letters. And space between lines is too small. Check screenshots below (red arrows show some examples).

On Firefox text is not cropped, but line-height is still too small.

I fix it in a custom header template with CSS:

/* Prevent cropped commits code fonts */
.lines-code pre code {
  line-height: 19px;
}
  
/* Prevent cropped commit description fonts (Fixes #1133) */
.repository.diff .ui.top.attached.info.clearing.segment pre {
  line-height: 13px;
}

... but I believe you would like to fix it globally.

Screenshots

cropped2

cropped

@silverwind
Copy link
Member

This sounds like a Chromium bug. Does it work in the release version of Chrome?

@rvillablanca
Copy link
Contributor

rvillablanca commented Jun 4, 2018

On Ubuntu 18.04 with Chrome 67.0.3396.62, the same happens.
It seems the bug is related with libfreetype6. adobe/brackets#14290
Related: gogs/gogs#5232

@lunny lunny added type/bug status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Jun 5, 2018
@mrsdizzie
Copy link
Member

Upstream bug which has fixes in linked issue and is out of our control. Anybody having a similar problem can find information in brackets issue above

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug
Projects
None yet
Development

No branches or pull requests

5 participants