Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not" checker will fail due to error string is not empty #63

Open
shinningstar opened this issue Nov 4, 2015 · 0 comments
Open

"Not" checker will fail due to error string is not empty #63

shinningstar opened this issue Nov 4, 2015 · 0 comments

Comments

@shinningstar
Copy link

https://github.com/go-check/check/blob/v1/helpers.go#L215

Method "internalCheck" does not only check the result returned by checker, but also check if error message is empty. The problem is about the "Not" checker. It only inverts the result, but not clears error message. It does make sense that every checker returns error message if result is false. So internalCheck reports fail when using Not checker. I think it should be a bug here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant