Skip to content

Commit 27de867

Browse files
committed
Fix buggy git grep pathspec args
To ensure that all necessary files are included in the explicit-exceptions-list.txt file and unwanted files and directories are not.
1 parent 2e9c239 commit 27de867

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Diff for: fuzzing/oss-fuzz-scripts/container-environment-bootstrap.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,12 @@ create_seed_corpora_zips "$WORK/qa-assets/gitpython/corpora"
9292
prepare_dictionaries_for_fuzz_targets "$WORK/qa-assets/gitpython/dictionaries" "$SRC/gitpython/fuzzing"
9393

9494
pushd "$SRC/gitpython/"
95-
# Search for 'raise' and 'assert' statements in Python files within GitPython's 'git/' directory and its submodules,
96-
# remove trailing colons, and save to 'explicit-exceptions-list.txt'. This file can then be used by fuzz harnesses to
97-
# check exception tracebacks:
98-
# If an exception found by the fuzzer originated in a file + line number in explicit-exceptions-list.txt, then it is not a bug.
95+
# Search for 'raise' and 'assert' statements in Python files within GitPython's source code and submodules, saving the
96+
# matched file path, line number, and line content to a file named 'explicit-exceptions-list.txt'.
97+
# This file can then be used by fuzz harnesses to check exception tracebacks and filter out explicitly raised or otherwise
98+
# anticipated exceptions to reduce false positive test failures.
9999

100-
git grep -n --recurse-submodules -e '\braise\b' -e '\bassert\b' -- "git/**/*.py" > "$SRC/explicit-exceptions-list.txt"
100+
git grep -n --recurse-submodules -e '\braise\b' -e '\bassert\b' -- '*.py' -- ':!setup.py' -- ':!test/**' -- ':!fuzzing/**' > "$SRC/explicit-exceptions-list.txt"
101101

102102
popd
103103

0 commit comments

Comments
 (0)