twss script appears to be missing

[timfallmk]

twss.coffee fails to fetch when updating hubot scripts (or running hubot).

Going to https://github.com/github/hubot-scripts/blob/master/src/scripts/twss.coffee gives a 404.

Error from hubot-scripts fetch:

ERROR Unable to load /home/ubuntu/MidoBot/node_modules/hubot-scripts/src/scripts/twss: Error: Cannot find module '/home/ubuntu/MidoBot/node_modules/hubot-scripts/src/scripts/twss'
  at Function.Module._resolveFilename (module.js:338:15)
  at Function.Module._load (module.js:280:25)
  at Module.require (module.js:364:17)
  at require (module.js:380:17)
  at Robot.loadFile (/home/ubuntu/MidoBot/node_modules/hubot/src/robot.coffee:216:9, <js>:162:11)
  at Robot.loadHubotScripts (/home/ubuntu/MidoBot/node_modules/hubot/src/robot.coffee:243:7, <js>:195:28)
  at /home/ubuntu/MidoBot/node_modules/hubot/bin/hubot:98:15, <js>:99:30
  at fs.js:268:14
  at Object.oncomplete (fs.js:107:15)

Backend problem?

[technicalpickles]

How are you fetching this exactly? If you are using the hubot-scripts, you'd normally specify the scripts to use in hubot-scripts.json.

In this case, it looks twss.coffee was removed in #1330 . If it's something you still want and need, I could see it coming back as an external script cc #1113

[timfallmk]

@technicalpickles It's being fetched during startup, and using the direct git link (as mentioned above).

I didn't realize it was removed until you said it. If it was removed, it would be nice to be notified of that, rather than getting a 'not found' error upon launch.

It also still appears in the catalogue.

[technicalpickles]

It also still appears in the catalogue.

I don't have control of the catalogue unfortunately. It's over at https://github.com/Aupajo/hubot-script-catalog/issues ... and actually, there's an issue already cc Aupajo/hubot-script-catalog#6

[technicalpickles]

I didn't realize it was removed until you said it. If it was removed, it would be nice to be notified of that, rather than getting a 'not found' error upon launch.

Agree. I think this means that basically we can't remove script files from hubot-scripts. We can, however, replace them with basically empty scripts that warn or error out with what to do to find them.

[technicalpickles]

It's being fetched during startup, and using the direct git link (as mentioned above).

I'm still not following. I don't see how you are fetching scripts from a git source at bot startup time. Could you walk me through what you are doing exactly?

Are you specifying hubot-scripts as a npm dependency, and pointing it at hubot-script's master branch?

[timfallmk]

Sorry, I should have been more clear here. It fails during the normal fetch
at startup tile. In addition the git page for that script is missing, as
you might expect.

On Tue, Apr 1, 2014 at 1:34 PM, Josh Nichols [email protected]:

It's being fetched during startup, and using the direct git link (as
mentioned above).

I'm still not following. I don't see how you are fetching scripts from a
git source at bot startup time. Could you walk me through what you are
doing exactly?

Are you specifying hubot-scripts as a npm dependency, and pointing it at
hubot-script's master branch?

Reply to this email directly or view it on GitHubhttps://github.com//issues/1386#issuecomment-39255119
.

[technicalpickles]

I'm still not 100% with you how you are fetching hubot-scripts every time... did you update your package.json to set the hubot-scripts version to work from git? I'd recommend using a specific version instead if possible, and that shouldn't happen.

The point is taken though about scripts being removed.