You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that in BbsClient and AdoClient we are not disposing the HTTP response that is getting returned by the HttpClient. The response needs to be immediately disposed with a using statement and also all unit tests need to be fixed the way they were fixed in #925.
Todo
Dispose the http response in BbsClient#SendAsync() and AdoClient#SendAsync() methods
Bonus: Simplify SendAsync method in both BbsClient and AdoClient by replacing the switch statement with HttpClient#SendAsync() the way it is in GithubClient#SendAsync().
The text was updated successfully, but these errors were encountered:
I noticed that in
BbsClient
andAdoClient
we are not disposing the HTTP response that is getting returned by theHttpClient
. The response needs to be immediately disposed with ausing
statement and also all unit tests need to be fixed the way they were fixed in #925.Todo
BbsClient#SendAsync()
andAdoClient#SendAsync()
methodsHttpResponseMessage
when mockingHttpMessageHandler
(see Add retries to GetAllAsync and GetNonSuccessAsync in GithubClient #925)SendAsync
method in bothBbsClient
andAdoClient
by replacing the switch statement withHttpClient#SendAsync()
the way it is in GithubClient#SendAsync().The text was updated successfully, but these errors were encountered: