Broken git signing

[dParikesit]

Version

0.14.8

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

I'm using macos gitbutler with nix-darwin based gpg. Whenever I try to enable git signing, I always get this error

It used to work on a nightly version of gitbutler (I commented about it in #5022), but it's not working anymore. I don't know the exact version when it stopped working, but I can check it if you need it.

Also, git signing works normally on normal cli git.

How to reproduce (Optional)

No response

Expected behavior (Optional)

No response

Relevant log output (Optional)

[Byron]

Thanks a lot for reporting!

Could you try to run GitButler from a terminal (where Git CLI signing works) using /Applications/GitButler.app/Contents/MacOS/gitbutler-tauri?

If this works, we know that the environment is causing the issue. Here is where one could assure a shell is always used to invoke the GPG program, something that typically picks up more of the environment (but not necessarily all) that the user sees in a terminal.

gitbutler/crates/but-core/src/cmd.rs

Lines 4 to 17 in 2e0d0d7

	pub fn prepare_with_shell_on_windows(program: impl Into<OsString>) -> gix::command::Prepare {
	let prepare = gix::command::prepare(program);
	if cfg!(windows) {
	prepare
	.command_may_be_shell_script_disallow_manual_argument_splitting()
	// On Windows, this yields the Git-bundled `sh.exe`, which is what we want.
	.with_shell_program(gix::path::env::shell())
	// force using a shell, we want access to additional programs here
	.with_shell()
	.with_quoted_command()
	} else {
	prepare
	}
	}

If you confirm, I think we should just always invoke it in a shell to increase the chances of successful operation.

[dParikesit]

Yes it worked if I run gitbutler from the terminal