Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many buttons do nothing #7367

Open
ofek opened this issue Feb 23, 2025 · 6 comments
Open

Many buttons do nothing #7367

ofek opened this issue Feb 23, 2025 · 6 comments
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions UI Any broken visuals like layouts, colors etc.

Comments

@ofek
Copy link

ofek commented Feb 23, 2025

Version

0.14.8

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

The following non-exhaustive list of buttons do absolutely nothing.


File
-> Check for updates...

Image


Help
-> Keyboard Shortcuts
-> Share Debug Info

Image


Commit right click
-> Uncommit
-> Edit commit message
-> Edit commit

Image

The first one at least has a log:

2025-02-23T23:31:05.937633Z ERROR handle: crates\gitbutler-watcher\src\handler.rs:55: error=failed to handle virtual branch event

Caused by:
    0: failed to list virtual branches
    1: failed to write virtual branch Lane
    2: Access is denied. (os error 5) event=VirtualBranch(d45c1bd4-26e2-40e9-b7db-032bd4d39249)

Image

Some other logs from before, perhaps related or about different actions, not sure:

2025-02-23T20:45:55.003909Z ERROR get_base_branch_data:get_base_branch_data: crates\gitbutler-branch-actions\src\base.rs:50: error=errors.projects.default_target.not_found

Caused by:
    there is no default target project_id=d45c1bd4-26e2-40e9-b7db-032bd4d39249
2025-02-23T20:45:55.003919Z  INFO get_base_branch_data:get_base_branch_data: crates\gitbutler-branch-actions\src\base.rs:50: close time.busy=39.5µs time.idle=10.5µs project_id=d45c1bd4-26e2-40e9-b7db-032bd4d39249
2025-02-23T20:45:55.003941Z  INFO get_base_branch_data: crates\gitbutler-tauri\src\virtual_branches.rs:152: close time.busy=1.70ms time.idle=7.00µs project_id=d45c1bd4-26e2-40e9-b7db-032bd4d39249
2025-02-23T20:45:55.008013Z  INFO set_base_branch: crates\gitbutler-tauri\src\virtual_branches.rs:168: new project_id=d45c1bd4-26e2-40e9-b7db-032bd4d39249 branch="origin/master" push_remote=Some("origin")
2025-02-23T20:45:55.009708Z  INFO set_base_branch:create_snapshot: crates\gitbutler-oplog\src\oplog.rs:161: new project_id=d45c1bd4-26e2-40e9-b7db-032bd4d39249 branch="origin/master" push_remote=Some("origin")
2025-02-23T20:45:55.011136Z ERROR set_base_branch:create_snapshot: crates\gitbutler-oplog\src\oplog.rs:161: error=errors.projects.default_target.not_found

Caused by:
    there is no default target project_id=d45c1bd4-26e2-40e9-b7db-032bd4d39249 branch="origin/master" push_remote=Some("origin")

How to reproduce (Optional)

No response

Expected behavior (Optional)

No response

Relevant log output (Optional)

@ofek ofek added the bug Something isn't working label Feb 23, 2025
@Byron Byron added 🎉reproduced🎉 The issue could be reproduced by following the instructions UI Any broken visuals like layouts, colors etc. labels Feb 24, 2025
@Byron
Copy link
Collaborator

Byron commented Feb 24, 2025

Thanks a lot for reporting!

I could reproduce the following ineffective buttons:

  • File -> Check for Updates…
    • Even while an update was definitely available, it didn't show anything, also nothing in the logs
  • Help
    • Share Debug Info
    • Keyboard Shortcuts

However, the right-click menu functions all worked for me, so I'd think these are related to the now more common "Access Denied" errors we have been seeing on Windows. In these cases, I'd expect an error to popup though.

Let me CC @mtsgrd who might know what to do.

@ofek
Copy link
Author

ofek commented Feb 28, 2025

Is there any workaround I might try?

@Byron
Copy link
Collaborator

Byron commented Feb 28, 2025

May I assume that you are looking for a list of keyboard shortcuts? If so, this might help.

export const shortcuts = {
global: {
open_repository: {
title: 'Add local repository…',
keys: '$mod+O',
description: null
},
clone_repository: {
title: 'Clone repository',
keys: '$mod+Shift+O',
description: null
}
},
view: {
switch_theme: {
title: 'Switch theme',
keys: '$mod+T',
description: null
},
toggle_sidebar: {
title: 'Toggle sidebar',
keys: '$mod+\\',
description: null
},
zoom_in: {
title: 'Zoom in',
keys: '$mod+=',
description: null
},
zoom_out: {
title: 'Zoom out',
keys: '$mod+-',
description: null
},
reset_zoom: {
title: 'Reset zoom',
keys: '$mod+0',
description: null
},
reload_view: {
title: 'Reload view',
keys: '$mod+R',
description: null
}
},
project: {
project_history: {
title: 'Project history',
description: 'Opens the project history view. Revert changes, view commits, and more.',
keys: '$mod+Shift+H'
}
}
};

There may be more subtle keys and navigation options, but it seems they wouldn't be documented here.

@ofek
Copy link
Author

ofek commented Feb 28, 2025

Oh, my apologies for being so terse. I mean is the "Access Denied" error something I can resolve or should I wait some amount of time for this project to fix it?

@Byron
Copy link
Collaborator

Byron commented Feb 28, 2025

Right! I would expect the next major release to perform significantly better in that regard, and there are good chances this issue will go away or be much more rare.
Sorry for the hassle.

@ofek
Copy link
Author

ofek commented Mar 5, 2025

No worries, I'm just excited to use this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🎉reproduced🎉 The issue could be reproduced by following the instructions UI Any broken visuals like layouts, colors etc.
Projects
None yet
Development

No branches or pull requests

2 participants