Skip to content

Commit 7d53e0f

Browse files
committed
prevent trashing when building with rustc in Jetbrains IDEs.
For the IDE to discover what's going on, it will use hidden environment variables to perform the build with, but that also affects certain crates which then report they changed. If this is intermixed with actual nightly builds, unnecessary rebuilds happen all the time. To prevent this, just use `nightly` by default without actually using nightly features.
1 parent 626ae0e commit 7d53e0f

File tree

4 files changed

+4
-16
lines changed

4 files changed

+4
-16
lines changed

.github/actions/init-env-rust/action.yaml

-10
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,6 @@ description: prepare runner for rust related tasks
33
runs:
44
using: "composite"
55
steps:
6-
- name: Setup Nightly
7-
if: runner.os == 'Windows'
8-
shell: bash
9-
run: |
10-
mv rust-toolchain.toml.windows rust-toolchain.toml
11-
- name: Setup Stable
12-
if: runner.os != 'Windows'
13-
shell: bash
14-
run: |
15-
mv rust-toolchain.toml.stable rust-toolchain.toml
166
- name: Check versions
177
shell: bash
188
run: |

DEVELOPMENT.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,10 @@ Building on Windows is a bit of a tricky process. Here are some helpful tips.
164164

165165
#### Nightly Compiler
166166

167-
As a few crates require nightly features on Windows, it's easiest to set an override
168-
to automatically use a nightly compiler.
167+
As a few crates require nightly features on Windows, a `rust-toolchain.toml` is provided
168+
to have rustup use the right compiler version.
169+
170+
If for some reason this cannot be used or doesn't kick-in, one can also set an override.
169171

170172
```shell
171173
rustup override add nightly-2024-07-01
File renamed without changes.

rust-toolchain.toml.stable

-4
This file was deleted.

0 commit comments

Comments
 (0)