Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: static import of img source #52

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Nov 26, 2024

☕️ Reasoning

  • Avoid need for manually passing width/height

🧢 Changes

  • Statically import local image assets
    • Next.js can then read the height/width as well optimize it for the clients size
    • Next.js image optimize doesnt support avif; so some had to be converted to png
  • Add "shimmer" image placeholder
wfrecording_2024-11-26_11.38.18.mp4

Recorded with networkThrottle: '3g'

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:40am

@ndom91 ndom91 force-pushed the ndom91/update-image-section-src branch from 8614d48 to 05e80a8 Compare November 26, 2024 11:39
@ndom91 ndom91 marked this pull request as ready for review November 26, 2024 11:39
@PavelLaptev PavelLaptev self-requested a review November 26, 2024 12:18
@ndom91 ndom91 merged commit b116a23 into main Nov 26, 2024
3 checks passed
@ndom91 ndom91 deleted the ndom91/update-image-section-src branch November 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants