Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-english pages no longer have the download option #1963

Closed
Sherry520 opened this issue Mar 1, 2025 · 3 comments · Fixed by #1964
Closed

Non-english pages no longer have the download option #1963

Sherry520 opened this issue Mar 1, 2025 · 3 comments · Fixed by #1964
Labels

Comments

@Sherry520
Copy link

Which download is failing?

https://git-scm.com/book/zh/v2

Problem

I remember there used to be a download option here, now there isn't. The English page works fine

Image

Operating system and browser

win10 chrome

Steps to reproduce

  1. Open the Chinese version of the website

Other details

@Sherry520 Sherry520 added the bug label Mar 1, 2025
@dscho
Copy link
Member

dscho commented Mar 1, 2025

Indeed, it seems that on Sep 17th, 2024 the download links were still there, but on Oct 15th, 2024 they were gone...

@dscho
Copy link
Member

dscho commented Mar 1, 2025

It might be due to the migration to Hugo (which happened on Sep 24th, 2024).

dscho added a commit to dscho/git-scm.com that referenced this issue Mar 1, 2025
…ions

In the transition to the Hugo world, these download links were lost.

By using the just-introduced feature where `script/update-book2.rb` can
work on a clone of the (potentially translated) ProGit book but also
discover dynamically in what format the book can be downloaded (if any),
we can add those back.

This closes git#1963.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member

dscho commented Mar 1, 2025

@Sherry520 please have a look at #1964 (and review to the best of your abilities).

@dscho dscho closed this as completed in f484ffc Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants