Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is not working #1280

Closed
pedrorijo91 opened this issue Nov 29, 2018 · 2 comments · Fixed by #1282
Closed

Search is not working #1280

pedrorijo91 opened this issue Nov 29, 2018 · 2 comments · Fixed by #1282
Assignees

Comments

@pedrorijo91
Copy link
Member

pedrorijo91 commented Nov 29, 2018

as reported in #1109

may be useful: #822 and #659

@pedrorijo91
Copy link
Member Author

quick update:

I decided to look a bit at this today, and I have a WIP branch: abfdd86

I needed to change the query a bit, most probably because I may be running with a different local version that what we have online, I need to check with PROD environment. But was able to use the newer client for the ES stuff.

I saw that the ES populate logic is under the .indexmethod for Searchable entities (section and doc_version). I haven't populated my ES storage,and I'm pretty sure that as soon as I test with real data I will need to update the result processing step as the format seems different from Tire.

Will try to find time during the upcoming week to have a 100% functional version

@pedrorijo91
Copy link
Member Author

it works on my machine :) https://github.com/git/git-scm.com/compare/fix/es-search

will try to clear the TODOs 'till end of week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant