Skip to content

Commit b091380

Browse files
committed
Convert to single-module architecture
The Go project recommends single-module repositories over multi-module wherever possible [1]; multi-module setups seem to be most useful when they represent separately-versioned and released projects living within the same repository (further analysis in [2]). Additionally, there is currently no convenient way to test all modules in a 'go.work' file (see [3]). Due to the factors listed, convert repository from multi- to single-module. [1] https://github.com/golang/go/wiki/Modules#should-i-have-multiple-modules-in-a-single-repository [2] https://medium.com/compass-true-north/catching-up-with-the-world-go-modules-in-a-monorepo-c3d1393d6024 [3] golang/go#50745 Signed-off-by: Victoria Dye <[email protected]>
1 parent 6316ccf commit b091380

File tree

8 files changed

+2
-37
lines changed

8 files changed

+2
-37
lines changed

.github/workflows/main.yml

+2-8
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,9 @@ jobs:
1717
path: src/git-bundle-server
1818

1919
- name: Build
20-
run: |
21-
cd $GITHUB_WORKSPACE/src/git-bundle-server
22-
GOPATH="$GITHUB_WORKSPACE/../../" go build ./cmd/git-bundle-server
23-
GOPATH="$GITHUB_WORKSPACE/../../" go build ./cmd/git-bundle-web-server
20+
run: go build -v src/git-bundle-server/...
2421

2522
- name: Check style
26-
run: |
27-
cd $GITHUB_WORKSPACE/src/git-bundle-server
28-
GOPATH="$GITHUB_WORKSPACE/../../" go vet ./cmd/git-bundle-server
29-
GOPATH="$GITHUB_WORKSPACE/../../" go vet ./cmd/git-bundle-web-server
23+
run: go vet src/git-bundle-server/...
3024

3125
# TODO: add automated tests.

cmd/git-bundle-server/go.mod

-3
This file was deleted.

cmd/git-bundle-web-server/go.mod

-3
This file was deleted.

go.mod

-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
11
module github.com/github/git-bundle-server
22

33
go 1.19
4-
5-
require (
6-
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 // indirect
7-
golang.org/x/tools v0.1.12 // indirect
8-
)

go.work

-9
This file was deleted.

internal/bundles/go.mod

-3
This file was deleted.

internal/core/go.mod

-3
This file was deleted.

internal/git/go.mod

-3
This file was deleted.

0 commit comments

Comments
 (0)