macOS quick terminal: auto hiding dock not restored

[criphc]

the issue: dock not restored to not autohidden after closing quick terminal.

how to reproduce:

1. set dock to the right and "Automatically hide and show the Dock" to false
2. open quick terminal in a desktop space
3. switch space to a native fullscreen window with the quick terminal open
4. close the quick terminal
5. switch back to desktop space

example:

Screen.Shot.2025-02-07.at.11.18.17.mp4

[taylrfnt]

I cannot reproduce this on the following Ghostty version:

❯ ghostty +version
Ghostty 1.1.1-main+cdd20990

Version
  - version: 1.1.1-main+cdd20990
  - channel: tip
Build Config
  - Zig version: 0.13.0
  - build mode : builtin.OptimizeMode.ReleaseFast
  - app runtime: apprt.Runtime.none
  - font engine: font.main.Backend.coretext
  - renderer   : renderer.Metal
  - libxev     : main.Backend.kqueue

I don't have a trackpad (my test environment is a Mac Mini) nor mouse gestures enabled for Mission Control, so I'm limited to the ctrl+arrrows to navigate between screens. Are you by chance using the trackpad to navigate between "desktops"?

[criphc]

I tried again on version 1.1.1-main+f95f636f. it still happens when I use ctrl+arrrows to navigate between screens:

Screen.Shot.2025-02-08.at.11.38.07.mp4

switching between desktop screens or fullscreen windows works fine, the issue only happens when switching between desktop and a fullscreen window.

I'm using a M1 MacBook Pro with macOS 15.3.

[taylrfnt]

Ok, so it looks like Dock positioning is relevant here...

If the Dock is on the bottom of the screen, like mine was earlier (oops) there's no issue. I have had it there so long I didn't even realize yours was on the right). If the Dock is on the left or the right, then this is reproducible on both stable and tip. Thanks for that second video, I'm not sure if I would have caught the different Dock position 😄

[taylrfnt]

There's two distinct PRs for auto-hide behavior (#5361 and #5363), so I tried to do some bisecting today and it looks like this behavior (bug) is introduced with a58b199

The initial PR @ commit a5a73f8 actually does not toggle the Dock setting (though the Dock is hidden somehow):
https://github.com/user-attachments/assets/dc620778-bc2d-4fef-9479-001982cde2e3

The second PR @ commit a58b199 does toggle the Dock visibility setting, and is the first build I can properly reproduce this behavior in. I'll go ahead and drop this discussion reference into that PR.

[mitchellh]

Thanks, #5685