You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When Vulkan sets VkPhysicalDeviceFeatures::shaderInt64, wgpu offers Features::SHADER_INT64, which, if enabled, causes Naga to permit 64-bit atomic types, even though those are covered by the separate VkPhysicalDeviceVulkan12Features::shaderSharedInt64Atomics and shaderBufferInt64Atomics features.
Okay, I see. I was only looking at the validation of Statement::Atomic and Expression::AtomicResult. But validate_atomic does verify that Statement::Atomic::pointer is a pointer to an atomic type, so the validation of the type itself effectively covers the statements.
This means that the call to Validator::check_width when validating Expression::AtomicResult is redundant - but #5742 covers that and more.
When Vulkan sets
VkPhysicalDeviceFeatures::shaderInt64
, wgpu offersFeatures::SHADER_INT64
, which, if enabled, causes Naga to permit 64-bit atomic types, even though those are covered by the separateVkPhysicalDeviceVulkan12Features::shaderSharedInt64Atomics
andshaderBufferInt64Atomics
features.This seems to be fixed by #5383.
The text was updated successfully, but these errors were encountered: